fix(google-signin): return tokenString instead of GIDToken object on iOS #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On iOS, `getTokens()` returns native `GIDToken` objects instead of token strings, making the tokens unusable in JavaScript. Use `.tokenString` property from `GIDToken` objects to extract actual token values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix iOS token retrieval returning GIDToken object instead of string value.
Problem
On iOS,
getTokens()returns nativeGIDTokenobjects instead of token strings, making the tokens unusable in JavaScript.Solution
Use
.tokenStringproperty fromGIDTokenobjects to extract actual token values.Testing
Platforms affected