Skip to content

bugfix(android): Fixes crash on sdk27+ devices when saving to gallery #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdamAtri wants to merge 2 commits into from
Closed

bugfix(android): Fixes crash on sdk27+ devices when saving to gallery #237

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc4b9eb
Fixes crash on android due to uncreated file.
AdamAtri Jan 20, 2020
d4da0dc
refactor: refactor variable names
AdamAtri Jan 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/camera.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,13 @@ export let takePicture = function (options?): Promise<any> {
let tempPictureUri;

if (saveToGallery) {
picturePath = android.os.Environment.getExternalStoragePublicDirectory(
android.os.Environment.DIRECTORY_DCIM).getAbsolutePath() + "/Camera/" + "NSIMG_" + dateStamp + ".jpg";

// reference the expected public output dir
const outputPath = android.os.Environment.getExternalStoragePublicDirectory(android.os.Environment.DIRECTORY_DCIM).getAbsolutePath() + "/Camera/";
const outputDir = new java.io.File(outputPath);
// and create it, if it doesn't exist (Android won't do it on 28+)
if (!outputDir.exists())
outputDir.mkdir();
picturePath = outputDir.getAbsolutePath() + "/NSIMG_" + dateStamp + ".jpg";
nativeFile = new java.io.File(picturePath);
} else {
picturePath = utils.ad.getApplicationContext().getExternalFilesDir(null).getAbsolutePath() + "/" + "NSIMG_" + dateStamp + ".jpg";
Expand Down Expand Up @@ -111,6 +115,12 @@ export let takePicture = function (options?): Promise<any> {
}
}

// verify that there is a file where we expect one
const picFile = new java.io.File(picturePath);
if (! picFile.exists()) {
return reject('Cannot locate the picture file');
}

let exif = new android.media.ExifInterface(picturePath);
let orientation = exif.getAttributeInt(android.media.ExifInterface.TAG_ORIENTATION,
android.media.ExifInterface.ORIENTATION_NORMAL);
Expand Down