Skip to content

fix: add default values for optional parameters in events #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −17
Open

fix: add default values for optional parameters in events #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Events/AutoUpdater/Error.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class Error implements ShouldBroadcastNow
public function __construct(
public string $name,
public string $message,
public ?string $stack,
public ?string $stack = null,
) {}

public function broadcastOn()
Expand Down
8 changes: 4 additions & 4 deletions src/Events/AutoUpdater/UpdateAvailable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ public function __construct(
public string $version,
public array $files,
public string $releaseDate,
public ?string $releaseName,
public string|array|null $releaseNotes,
public ?int $stagingPercentage,
public ?string $minimumSystemVersion,
public ?string $releaseName = null,
public string|array|null $releaseNotes = null,
public ?int $stagingPercentage = null,
public ?string $minimumSystemVersion = null,
) {}

public function broadcastOn()
Expand Down
8 changes: 4 additions & 4 deletions src/Events/AutoUpdater/UpdateCancelled.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ public function __construct(
public string $version,
public array $files,
public string $releaseDate,
public ?string $releaseName,
public string|array|null $releaseNotes,
public ?int $stagingPercentage,
public ?string $minimumSystemVersion,
public ?string $releaseName = null,
public string|array|null $releaseNotes = null,
public ?int $stagingPercentage = null,
public ?string $minimumSystemVersion = null,
) {}

public function broadcastOn()
Expand Down
8 changes: 4 additions & 4 deletions src/Events/AutoUpdater/UpdateDownloaded.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ public function __construct(
public string $version,
public array $files,
public string $releaseDate,
public ?string $releaseName,
public string|array|null $releaseNotes,
public ?int $stagingPercentage,
public ?string $minimumSystemVersion
public ?string $releaseName = null,
public string|array|null $releaseNotes = null,
public ?int $stagingPercentage = null,
public ?string $minimumSystemVersion = null,
) {}

public function broadcastOn()
Expand Down
8 changes: 4 additions & 4 deletions src/Events/AutoUpdater/UpdateNotAvailable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ public function __construct(
public string $version,
public array $files,
public string $releaseDate,
public ?string $releaseName,
public string|array|null $releaseNotes,
public ?int $stagingPercentage,
public ?string $minimumSystemVersion,
public ?string $releaseName = null,
public string|array|null $releaseNotes = null,
public ?int $stagingPercentage = null,
public ?string $minimumSystemVersion = null,
) {}

public function broadcastOn()
Expand Down
Loading