-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concept page mappings: style and visibility fixes #1613
Concept page mappings: style and visibility fixes #1613
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1613 +/- ##
=========================================
Coverage 70.58% 70.58%
Complexity 1647 1647
=========================================
Files 32 32
Lines 4321 4321
=========================================
Hits 3050 3050
Misses 1271 1271 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Some kind of indication that the mappings are being loaded could be added but not necessarily in this PR.
There is also a very minor issue with the mappings
variable but it doesn't affect functionality.
|
Fixed the mappings initialization and added the spinner to the TODO list in the conccept page issue. Merging this now. |
Reasons for creating this PR
The layout and styling of concept mappings was wrong after opening the vocabulary home page and clicking on links that perform a partial page load. Also, when switching between concepts, the mappings didn't update immediately, so the wrong (stale) set of mappings could be shown.
This PR addresses the above problems by adjusting the template structure of the concept-mappings Vue component and making the display of the
div
element with the actual mappings conditional on the existence of mappings.Link to relevant issue(s), if any
Description of the changes in this PR
div
conditional on the existence of mappings (using a computed value for clarity)Known problems or uncertainties in this PR
div
in the DOM structure. I couldn't figure out how to avoid it. I tried changing it totemplate
instead in the Vue template, but it just ended up in the DOM as<template>
and broke the functionality.Checklist
.sr-only
class, color contrast)