Fix copy_object and list_objects_by_class#90
Open
akrivi wants to merge 4 commits intoNatLabRockies:mainfrom
Open
Fix copy_object and list_objects_by_class#90akrivi wants to merge 4 commits intoNatLabRockies:mainfrom
akrivi wants to merge 4 commits intoNatLabRockies:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following:
list_objects_by_class: Filtering objects by category is now correctly implemented.copy_object: Previously, properties were being copied even when copy_properties = false. Also, for the case where copy_properties = true, properties were not copied correctly._copy_object_properties: Previously, properties associated with scenarios were not copied correctly, leading to missing scenario data on copied objects.copy_object_memberships:- It is possible to have objects with memberships where the parent and child objects share the same name but different class. The previous implementation used name-based logic, which caused these memberships to be skipped.
- Certain Class and Collection names in the db use names with spaces (eg. "ST Schedule", "Head Storage"), while the corresponding Enums use normalized names. Previously, this caused failures when copying memberships for certain objects (eg. Model), since the enum lookup would raise errors. (This is not an issue when using SQL queries)