Fix extreme grade at low distance - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28 by adding a minimum distance threshold for computing the grade from the rise over run between points. As distances approach zero, the grade grows asymptotically and so we allow the caller to define when those distances should be ignored. The default value is 1ft but this might need to be tuned depending on the nature of the data. If a segment falls below this distance, the previous grade is carried forward. In the vehicle space, this could represent when a vehicle comes to a stop and the distance approaches zero as the speed approaches zero. In those cases, the previous grade is valid since the vehicle has not moved in space.