fix: address review feedback on semantic memory - #791
Open
Dhirenderchoudhary wants to merge 1 commit into
Open
Conversation
Dhirenderchoudhary
marked this pull request as ready for review
August 6, 2026 10:10
Dhirenderchoudhary
requested review from
Avtrkrb,
akramcodez and
will-lamerton
as code owners
August 6, 2026 10:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
findRelevantMemoriesso incidental word overlap (e.g. "the", "in") no longer scores as relevant/memory propose: capped candidates per message and truncated evidence to snippets instead of full messages; explicit user statements can now be proposed even without matching one of the five keyword categories, while uncategorized assistant chatter is still filtered out/memory accept <n>to save a proposal directly instead of retyping it into/remember--plainand--acp, matching what the TUI already did (previously memories saved on those surfaces were never recalled)semanticMemoryEnabledsetting now gates writes (/remember,/memory accept), not just recalldocs/features/semantic-memory.mdand/remember//memoryentries incommands.mdSemanticMemoryManager, fixed the token-budget loop silently reordering memories by size, fenced the injected memory content in the system prompt, removed a deadMemorySourceTypevalue, fixed an order-dependent warning on accepted proposalsCloses #619
Type of Change
Changeset
pnpm changeset) describing this change for the changelogTesting
Automated Tests
.spec.ts/tsxfilespnpm test:allcompletes successfully)Manual Testing
Checklist