Update ExprChecks for RowNumber. #12178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The supportedExprs.csv currently do not currently state that the RowNumber
window function does not support an `Array` order-by column.
Indeed, on running such a query, one sees that the operation falls back to
CPU:
```
scala> sql(" select row_number() over ( order by id_array ) from ... ").show
...
!Expression <WindowSpecDefinition> windowspecdefinition(id_array#28 ASC NULLS FIRST, specifiedwindowframe(RowFrame, unboundedpreceding$(), currentrow$())) cannot run on GPU because order expression SortOrder id_array#28 ASC NULLS FIRST (ArrayType(LongType,true) is not supported)
```
This commit updates the registration of the RowNumber window fuction in
`GpuOverrides`, to allow for the generated documentation to be updated.
Note that RowNumber could well implemented to work in this case also,
at a later date. That is out of the scope of this current change.
Signed-off-by: MithunR <[email protected]>
mythrocks
force-pushed
the
update-rownumber-expr-checks
branch
from
fcdde5f to
408b67f
Compare
|
Build |
|
For the record, this isn't only an update to documentation. This has an effect on how the fallback is signaled when the query is run. |
|
I have filed another issue to improve |
revans2
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The supportedExprs.csv currently do not currently state that the RowNumber window function does not support an
Arrayorder-by column.Indeed, on running such a query, one sees that the operation falls back to CPU:
This commit updates the registration of the RowNumber window fuction in
GpuOverrides, to allow for the generated documentation to be updated.Note that RowNumber could well be implemented to work in this case also, at a later date. That is out of the scope of this current change.