Skip to content

Avoids float-casting of CUDA version strings to preemptively prevent CUDA extension install bugs#224

Merged
ktangsali merged 9 commits intoNVIDIA:mainfrom
peterdsharpe:psharpe/cuda_version_handling_fix
Feb 11, 2026
Merged

Avoids float-casting of CUDA version strings to preemptively prevent CUDA extension install bugs#224
ktangsali merged 9 commits intoNVIDIA:mainfrom
peterdsharpe:psharpe/cuda_version_handling_fix

Conversation

@peterdsharpe
Copy link
Collaborator

@peterdsharpe peterdsharpe commented Feb 27, 2025

Modulus Pull Request

Description

Minor fix to preemptively prevent failing installs for future CUDA versions, such as:

  • "12.8-rc.2" -> ValueError
  • "11.10" -> interpreted as 11.1

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@peterdsharpe
Copy link
Collaborator Author

/blossom-ci

@ktangsali
Copy link
Collaborator

/blossom-ci

…error for CPU-only PyTorch installations and add type hint for return type.
@ktangsali
Copy link
Collaborator

/blossom-ci

@peterdsharpe peterdsharpe requested a review from ktangsali June 11, 2025 19:48
Copy link
Collaborator

@ktangsali ktangsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@ktangsali
Copy link
Collaborator

/blossom-ci

3 similar comments
@NickGeneva
Copy link
Collaborator

/blossom-ci

@ktangsali
Copy link
Collaborator

/blossom-ci

@ktangsali
Copy link
Collaborator

/blossom-ci

@peterdsharpe
Copy link
Collaborator Author

/blossom-ci

@ktangsali
Copy link
Collaborator

/blossom-ci

1 similar comment
@ktangsali
Copy link
Collaborator

/blossom-ci

@ktangsali ktangsali merged commit 6947398 into NVIDIA:main Feb 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants