hydra compose register_amp_configs() fix#215
Closed
n0k0m3 wants to merge 1 commit intoNVIDIA:mainfrom
Closed
Conversation
Close NVIDIA#206 `register_amp_configs()` was called in main() register_decorator but missing in compose(). When user uses compose() to get config it will fail since it can’t find any registered amp defaults.
ZBDat
reviewed
Jan 27, 2025
ZBDat
left a comment
ZBDat
left a comment
There was a problem hiding this comment.
This bug will cause the notebook workflow failure since hydra.compose will be called. The output became nomal after I did the exact same change to the site package as in this commit and caused no other effects.
ktangsali
added a commit
to ktangsali/physicsnemo-sym
that referenced
this pull request
Feb 11, 2026
5 tasks
Collaborator
|
Since Modulus has been renamed to PhysicsNeMo, merging this PR will cause a lot of conflicts and rebasing it is not simple. As a workaround, I have pulled in the changes from this PR in #281 Thank you for your contribution! |
ktangsali
added a commit
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modulus Pull Request
Description
Close #206
register_amp_configs()was called in main() register_decorator but missing in compose(). When user uses compose() to get config it will fail since it can’t find any registered amp defaults.Checklist
Dependencies