Skip to content

fix(self-managed): bump sis, nvcf-api, and nvct-api chart pins#434

Open
along-2017 wants to merge 1 commit into
mainfrom
along/chore/bump-self-managed-charts
Open

fix(self-managed): bump sis, nvcf-api, and nvct-api chart pins#434
along-2017 wants to merge 1 commit into
mainfrom
along/chore/bump-self-managed-charts

Conversation

@along-2017

@along-2017 along-2017 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

TL;DR

Bump three self-managed core stack chart pins to consume the latest released
charts: sis 1.18.3 -> 2.0.0, nvcf-api 1.23.9 -> 1.23.10, and nvct-api 1.4.3 -> 1.4.4.

Additional Details

Chart version pins in deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl
control which published chart each core NVCF service release deploys. This
change advances the sis, api, and nvct-api releases to their newest chart
versions. No other stack values or ordering change.

Background per chart:

  • sis 1.18.3 -> 2.0.0: major bump. The chart now ships hot-reloadable remote
    config for the service (config delivered through a namespace ConfigMap with
    RBAC and a service-account token reshape) and moves to the OSS service image
    with the ncp profile in self-hosted, plus a NATS reconnect fix. This is a
    breaking chart release, see Notes.
  • api 1.23.9 -> 1.23.10: patch bump that pulls in the newer OSS service image.
  • nvct-api 1.4.3 -> 1.4.4: patch bump that pulls in the newer OSS service image.

For the Reviewer

Single-file change; the diff is three version-line edits.

For QA

Not run yet. Recommend a helmfile template/diff against the self-managed
stack to confirm the pinned charts resolve, plus a deploy smoke on a test
cluster.

Notes

sis 2.0.0 is a breaking chart release. Two items to verify against the
self-managed stack values before deploy:

  • Volume keys renamed: sis.volumes -> sis.extraVolumes and
    sis.volumeMounts -> sis.extraVolumeMounts. The token volume and mount are
    now chart-owned; the chart fails rendering if the old keys are still set.
  • Remote config grants the service account list/watch on the namespace
    ConfigMap collection. Clusters that block broad namespace reads need a policy
    exception, or set sis.remoteConfig.enabled: false to opt out (hot reload
    then unavailable).

Issues

Relates to #ISSUE

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Summary by CodeRabbit

  • Updates
    • Updated core service chart versions.
    • Includes the latest releases for SIS, API, and NVCT API services.

Update self-managed core stack chart pins to consume the latest releases:

- sis: 1.18.3 -> 2.0.0
- api: 1.23.9 -> 1.23.10
- nvct-api: 1.4.3 -> 1.4.4

Signed-off-by: along <along@nvidia.com>
@along-2017 along-2017 self-assigned this Jul 24, 2026
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updates the chart versions for the sis, api, and nvct-api releases in the self-managed core Helmfile template.

Changes

Core Helm release updates

Layer / File(s) Summary
Update core service chart versions
deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl
Updates sis to 2.0.0, api to 1.23.10, and nvct-api to 1.4.4 without changing release wiring.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • NVIDIA/nvcf#392: Updates the sis chart version in the same Helmfile.
  • NVIDIA/nvcf#415: Preceding api chart version update in the same release declaration.

Suggested reviewers: max-nv

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes the chart pin bumps, but fix is the wrong Conventional Commits type for this maintenance-only version update. Change it to chore(self-managed): bump sis, api, and nvct-api chart pins to match the change’s maintenance nature.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch along/chore/bump-self-managed-charts

Comment @coderabbitai help to get the list of available commands.

@along-2017
along-2017 marked this pull request as ready for review July 24, 2026 23:10
@along-2017
along-2017 requested a review from a team as a code owner July 24, 2026 23:10
@along-2017
along-2017 requested review from borao, nvjmcnamee, sanjay-saxena and sbaum1994 and removed request for borao July 24, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant