Skip to content

Ensure that directory volumes have Directory type #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

Ensure that directory volumes have Directory type #1199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions deployments/helm/nvidia-device-plugin/templates/daemonset-device-plugin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ spec:
securityContext:
{{- include "nvidia-device-plugin.securityContext" . | nindent 10 }}
volumeMounts:
- name: device-plugin
- name: kubelet-device-plugins-dir
mountPath: /var/lib/kubelet/device-plugins
{{- if typeIs "string" .Values.nvidiaDriverRoot }}
# We always mount the driver root at /driver-root in the container.
Expand All @@ -223,20 +223,22 @@ spec:
{{- toYaml . | nindent 10 }}
{{- end }}
volumes:
- name: device-plugin
- name: kubelet-device-plugins-dir
hostPath:
path: /var/lib/kubelet/device-plugins
type: Directory
- name: mps-root
hostPath:
path: {{ .Values.mps.root }}
type: DirectoryOrCreate
- name: mps-shm
hostPath:
path: {{ .Values.mps.root }}/shm
{{- if typeIs "string" .Values.nvidiaDriverRoot }}
{{- if typeIs "string" .Values.nvidiaDriverRoot }}
- name: driver-root
hostPath:
path: {{ .Values.nvidiaDriverRoot }}
type: Directory
{{- end }}
- name: cdi-root
hostPath:
Expand Down
2 changes: 2 additions & 0 deletions deployments/helm/nvidia-device-plugin/templates/daemonset-gfd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,11 @@ spec:
- name: output-dir
hostPath:
path: "/etc/kubernetes/node-feature-discovery/features.d"
type: DirectoryOrCreate
- name: host-sys
hostPath:
path: "/sys"
type: Directory
- name: driver-root
hostPath:
path: {{ clean ( join "/" ( list "/" .Values.nvidiaDriverRoot ) ) | quote }}
Expand Down
2 changes: 2 additions & 0 deletions deployments/static/gpu-feature-discovery-daemonset-with-mig-mixed.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ spec:
- name: output-dir
hostPath:
path: "/etc/kubernetes/node-feature-discovery/features.d"
type: DirectoryOrCreate
- name: host-sys
hostPath:
path: "/sys"
type: Directory
2 changes: 2 additions & 0 deletions deployments/static/gpu-feature-discovery-daemonset-with-mig-single.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ spec:
- name: output-dir
hostPath:
path: "/etc/kubernetes/node-feature-discovery/features.d"
type: DirectoryOrCreate
- name: host-sys
hostPath:
path: "/sys"
type: Directory
2 changes: 2 additions & 0 deletions deployments/static/gpu-feature-discovery-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ spec:
- name: output-dir
hostPath:
path: "/etc/kubernetes/node-feature-discovery/features.d"
type: DirectoryOrCreate
- name: host-sys
hostPath:
path: "/sys"
type: Directory
2 changes: 2 additions & 0 deletions deployments/static/gpu-feature-discovery-job.yaml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ spec:
- name: output-dir
hostPath:
path: "/etc/kubernetes/node-feature-discovery/features.d"
type: DirectoryOrCreate
- name: host-sys
hostPath:
path: "/sys"
type: Directory
restartPolicy: Never
5 changes: 3 additions & 2 deletions deployments/static/nvidia-device-plugin-compat-with-cpumanager.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,10 @@ spec:
securityContext:
privileged: true
volumeMounts:
- name: device-plugin
- name: kubelet-device-plugins-dir
mountPath: /var/lib/kubelet/device-plugins
volumes:
- name: device-plugin
- name: kubelet-device-plugins-dir
hostPath:
path: /var/lib/kubelet/device-plugins
type: Directory
5 changes: 3 additions & 2 deletions deployments/static/nvidia-device-plugin-privileged-with-service-account.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,11 @@ spec:
securityContext:
privileged: true
volumeMounts:
- name: device-plugin
- name: kubelet-device-plugins-dir
mountPath: /var/lib/kubelet/device-plugins
serviceAccountName: nvidia-device-plugin
volumes:
- name: device-plugin
- name: kubelet-device-plugins-dir
hostPath:
path: /var/lib/kubelet/device-plugins
type: DirectoryOrCreate
5 changes: 3 additions & 2 deletions deployments/static/nvidia-device-plugin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,10 @@ spec:
capabilities:
drop: ["ALL"]
volumeMounts:
- name: device-plugin
- name: kubelet-device-plugins-dir
mountPath: /var/lib/kubelet/device-plugins
volumes:
- name: device-plugin
- name: kubelet-device-plugins-dir
hostPath:
path: /var/lib/kubelet/device-plugins
type: Directory
Copy link
Preview

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a spelling error in the PR title: 'direcory' should be 'directory'.

Copilot uses AI. Check for mistakes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ ^

Loading