[FEATURE] [HELM] Add support to disable MPS #1178
Open
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marino Borges <[email protected]>
marinoborges
changed the title
|
Unsure if we need also to change NVIDIA_DRIVER_CAPABILITIES env var value when running without MPS. |
chipzoller
reviewed
Feb 28, 2025
| @@ -145,6 +145,7 @@ nfd: | |||
| - vendor | |||
|
|
|||
| mps: | |||
| enabled: true | |||
There was a problem hiding this comment.
As a user, I think at a minimum there needs to be comments placed above this line to explain its use. If I see this in a values file, I may interpret mps.enabled: true to mean I, as a user, want MPS enabled right out of the gate. But that's not what this does. When set to false MPS will never work even if I later activate an MPS configuration by labeling a node.
There was a problem hiding this comment.
I added a comment clarifying this
Signed-off-by: Marino Borges <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1177 with backward compatibility so this should be a minor change.