Feat: Allow to configure kubelet root directory #1384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new configuration option
KubeletRootDir
to specify the root directory for the kubelet base directory. The changes include updates to the cluster policy types, CRD manifests, controllers, and tests to support this new configuration.Configuration Enhancements:
KubeletRootDir
field to theHostPathsSpec
struct inapi/nvidia/v1/clusterpolicy_types.go
to represent the kubelet base directory.bundle/manifests/nvidia.com_clusterpolicies.yaml
,config/crd/bases/nvidia.com_clusterpolicies.yaml
,deployments/gpu-operator/crds/nvidia.com_clusterpolicies.yaml
) to include the newKubeletRootDir
field.Controller Updates:
DefaultKubeletRootDir
constant and updatedpreProcessDaemonSet
function incontrollers/object_controls.go
to transform the kubelet root directory if a custom one is configured. [1] [2]transformForKubeletRootDir
function incontrollers/object_controls.go
to apply necessary transformations for custom kubelet root directory.Testing:
TestTransformForKubeletRootDir
function incontrollers/transforms_test.go
to validate the transformations for different kubelet root directory configurations.Deployment Configuration:
deployments/gpu-operator/templates/clusterpolicy.yaml
anddeployments/gpu-operator/values.yaml
to include the newkubeletRootDir
configuration. [1] [2]Closes #1358
Closes #745