Fix pre-Blackwell validation in the Ada FP8 GEMM example - #3411
Open
Lec16sf wants to merge 1 commit into
Open
Conversation
- Initialize the device support flag on every validation path - Require CUDA 12.4 and SM89 or newer for pre-Blackwell devices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore the pre-Blackwell device and CUDA Toolkit validation in example 58.
Problem
Starting with CUTLASS v4.0.0, the
props.major < 10branch inexamples/58_ada_fp8_gemm/ada_fp8_gemm.cuis empty:As a result, satisfied may be read without being initialized when running on a pre-Blackwell GPU. This is undefined behavior.
A supported GPU with compute capability 8.9 or greater and CUDA Toolkit 12.4 or later may therefore incorrectly enter the unsupported-device path and print:
CUTLASS's FP8 SM89 example requires an NVIDIA GPU with compute capability 8.9 or greater and CUDA toolkit version 12.4 or laterThe example then exits without running the GEMM.
Changes
Restore the pre-v4.0.0 validation logic for pre-Blackwell devices.
Testing
Built the example for SM89 with CUDA Toolkit 12.4 and ran it with reference checking enabled:
The results are as follows: