Use cuda::stream_ref for nested and IO APIs - #23669
Open
vyasr wants to merge 10 commits into
Open
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
vyasr
force-pushed
the
codex/cuda-stream-ref-batch-4
branch
from
August 15, 2026 22:22
dacc05a to
68e5399
Compare
vyasr
added
improvement
vyasr
marked this pull request as ready for review
August 15, 2026 22:24
github-actions
Bot
added
Python
bdice
approved these changes
Aug 16, 2026
bdice
left a comment
bdice
left a comment
Contributor
There was a problem hiding this comment.
I spot checked this and it uses <cuda/stream> and stream.sync() as desired. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fourth batch migrates libcudf IO, strings, lists, structs, text, and related nested APIs and tests from
rmm::cuda_stream_viewtocuda::stream_ref. It leaves default stream helpers and owning RMM stream types unchanged for a later batch.It also adds explicit stream coverage for scalar and string factory APIs.
Contributes to #23636
Checklist