[C++] [run] Allow returning vector of scalar types from entry-point kernels #3514

khalatepradnya · 2025-10-14T20:03:36Z

This PR enables the support for quantum kernels that return std::vector types in the cudaq::run API.

Add new negative tests for unsupported kernel return types,
Clean up related code and comments.

Note: Out-of-scope for this PR - Python changes

github-actions · 2025-10-14T21:37:02Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions · 2025-10-15T01:34:35Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions · 2025-10-15T18:46:40Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

schweitzpgi

Thank you for working on getting this enabled, Pradnya. Nice!

targettests/execution/cudaq_run.cpp

targettests/execution/cudaq_run_emulation.cpp

test/AST-error/run_vec_of_vec.cpp

test/AST-error/run_struct_of_vec.cpp

targettests/execution/cudaq_run.cpp

test/AST-error/run_vec_of_vec.cpp

… `run` API. Signed-off-by: Pradnya Khalate <[email protected]>

Signed-off-by: Pradnya Khalate <[email protected]>

github-actions · 2025-10-16T00:14:08Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions · 2025-10-16T21:51:55Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions · 2025-10-23T01:40:44Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

schweitzpgi

Thank you for enabling this. It's good to finish this for cudaq::run.

runtime/cudaq/qis/execution_manager.h

targettests/execution/cudaq_run.cpp

test/AST-error/run_vec_of_vec.cpp

`inline` is redundant here. Co-authored-by: Eric Schweitz <[email protected]> Signed-off-by: Pradnya Khalate <[email protected]>

Multi-line checks Co-authored-by: Eric Schweitz <[email protected]> Signed-off-by: Pradnya Khalate <[email protected]>

github-actions · 2025-10-23T20:13:14Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

coderabbitai · 2025-10-23T20:48:24Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

✅ Unit Test PR creation complete.

Create PR with unit tests
Commit unit tests in branch c++-run-vec-support
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-10-23T22:34:43Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

coderabbitai · 2025-10-23T22:46:03Z

Note

Unit test generation is an Early Access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Generating unit tests... This may take up to 20 minutes.

coderabbitai · 2025-10-23T22:46:06Z

Caution

The CodeRabbit agent failed during execution: Clone operation failed

github-actions · 2025-10-24T01:39:55Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

khalatepradnya added the enhancement New feature or request label Oct 14, 2025

github-actions bot pushed a commit that referenced this pull request Oct 14, 2025

Docs preview for PR #3514.

162b59a

github-actions bot pushed a commit that referenced this pull request Oct 15, 2025

Docs preview for PR #3514.

871b05d

khalatepradnya force-pushed the c++-run-vec-support branch from fa1e3d6 to a079c6b Compare October 15, 2025 17:03

github-actions bot pushed a commit that referenced this pull request Oct 15, 2025

Docs preview for PR #3514.

2086547

khalatepradnya marked this pull request as ready for review October 15, 2025 18:57

khalatepradnya requested review from 1tnguyen, bettinaheim, bmhowe23 and schweitzpgi October 15, 2025 18:57

schweitzpgi reviewed Oct 15, 2025

View reviewed changes

khalatepradnya commented Oct 15, 2025

View reviewed changes

test/AST-error/run_vec_of_vec.cpp Outdated Show resolved Hide resolved

khalatepradnya added 6 commits October 15, 2025 17:11

[C++] Allow returing vector of scalar types from kernels invoked with…

d51b5e2

… `run` API. Signed-off-by: Pradnya Khalate <[email protected]>

* Fix test - doesn't work in library mode

197555d

Signed-off-by: Pradnya Khalate <[email protected]>

* Failing tests - fix the RUN command

95cb476

Signed-off-by: Pradnya Khalate <[email protected]>

* Delete a negative test that works now

5669147

Signed-off-by: Pradnya Khalate <[email protected]>

* Addressing review comments

7778cef

Signed-off-by: Pradnya Khalate <[email protected]>

* Add a method to convert vector<measure_result> to vector<bool>

876c10b

Signed-off-by: Pradnya Khalate <[email protected]>

khalatepradnya force-pushed the c++-run-vec-support branch from 1b9100b to 876c10b Compare October 16, 2025 00:11

github-actions bot pushed a commit that referenced this pull request Oct 16, 2025

Docs preview for PR #3514.

98f8055

khalatepradnya self-assigned this Oct 16, 2025

Merge branch 'main' into c++-run-vec-support

e7ea3c7

github-actions bot pushed a commit that referenced this pull request Oct 16, 2025

Docs preview for PR #3514.

8a05f30

Merge branch 'main' into c++-run-vec-support

57d1669

github-actions bot pushed a commit that referenced this pull request Oct 23, 2025

Docs preview for PR #3514.

2cc1d81

schweitzpgi approved these changes Oct 23, 2025

View reviewed changes

runtime/cudaq/qis/execution_manager.h Outdated Show resolved Hide resolved

targettests/execution/cudaq_run.cpp Show resolved Hide resolved

test/AST-error/run_vec_of_vec.cpp Outdated Show resolved Hide resolved

test/AST-error/run_vec_of_vec.cpp Outdated Show resolved Hide resolved

khalatepradnya and others added 3 commits October 23, 2025 09:10

Update runtime/cudaq/qis/execution_manager.h

6ef4190

`inline` is redundant here. Co-authored-by: Eric Schweitz <[email protected]> Signed-off-by: Pradnya Khalate <[email protected]>

Update test/AST-error/run_vec_of_vec.cpp

b86ac45

Multi-line checks Co-authored-by: Eric Schweitz <[email protected]> Signed-off-by: Pradnya Khalate <[email protected]>

Merge branch 'main' into c++-run-vec-support

d7d74f6

khalatepradnya enabled auto-merge (squash) October 23, 2025 16:20

khalatepradnya disabled auto-merge October 23, 2025 16:29

Merge branch 'main' into c++-run-vec-support

2a6f856

khalatepradnya enabled auto-merge (squash) October 23, 2025 18:25

github-actions bot pushed a commit that referenced this pull request Oct 23, 2025

Docs preview for PR #3514.

cb825f1

Merge branch 'main' into c++-run-vec-support

f8351aa

github-actions bot pushed a commit that referenced this pull request Oct 23, 2025

Docs preview for PR #3514.

ca151bc

Merge branch 'main' into c++-run-vec-support

248912e

khalatepradnya merged commit a2988a4 into NVIDIA:main Oct 24, 2025
193 checks passed

github-actions bot pushed a commit that referenced this pull request Oct 24, 2025

Cleaning up docs preview for PR #3514.

c0a2cbb

khalatepradnya deleted the c++-run-vec-support branch October 24, 2025 02:52

Uh oh!

[C++] [run] Allow returning vector of scalar types from entry-point kernels #3514

[C++] [run] Allow returning vector of scalar types from entry-point kernels #3514

Uh oh!

Conversation

khalatepradnya commented Oct 14, 2025

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

schweitzpgi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

schweitzpgi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

coderabbitai bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

coderabbitai bot commented Oct 23, 2025

Uh oh!

coderabbitai bot commented Oct 23, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Oct 23, 2025 •

edited

Loading