Skip to content

Fixes for Python modulo operation #3513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Fixes for Python modulo operation #3513

wants to merge 36 commits into from

Conversation

bettinaheim
Copy link
Collaborator

Builds on #3489.
Pulled out of that PR per review request.

@bettinaheim
first draft for some bridge fixes
0351238 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
getting closer with the testing
6e2a893 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
more tests and fixes
461a32e 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
finished the tuple testing
3249b15 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
some clean up
1cf4e67 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
allow to deconstruct lists
77c02a8 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
more clean up
912c905 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
don't assume stack size
1b6024a 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
fixed controlled and adjoint
f8e7835 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
tests for callable kernel args with control and adjoint
9104265 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
argument conversion needs reexamination
0d8d34d 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
handling the vect<bool> conversion in the argument conversion
a5e4944 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
minor clean up
bd73206 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
some test clean up
95054ff 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
some test clean up
418ae3b 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
some bridge clean up
7fab128 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
added a test
c8c699d 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
more tests
3ada403 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
forgot something
7c48168 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
forgot something
9d611eb 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
moving processing of veq functions
8f5e619 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
minor things
a96dccd 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
reverting a bad change
8ed8d07 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
proper tests for comparison and found some bugs
6439bca 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
more tests
6fb2fe7 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
Merge branch 'main' into list-comprehension
cf202a1 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
we have some issues with data conversion for __quantum__* functions i…
0c03364 
…mplemented in nvqir

Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
Merge branch 'list-comprehension' of https://github.com/bettinaheim/c…
e164d88 
…uda-quantum into list-comprehension

Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
last remaining tests for now
8173b7b 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
forgot to commit matching bridge changes
383584b 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
adding missing return
4bae1a3 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
Merge branch 'main' into list-comprehension
de6e27e
@bettinaheim
formatting
e96b872 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
spelling
db8531d 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
more formatting
491994a 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim
more formatting
8c4eb96 
Signed-off-by: Bettina Heim <[email protected]>
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 14, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bettinaheim bettinaheim mentioned this pull request Oct 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1tnguyen 1tnguyen Awaiting requested review from 1tnguyen 1tnguyen is a code owner

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23 bmhowe23 is a code owner

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi schweitzpgi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bettinaheim