Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass of support for C++ operators #2511

Open
wants to merge 392 commits into
base: experimental/operators
Choose a base branch
from
Open

First pass of support for C++ operators #2511

wants to merge 392 commits into from

Conversation

anthony-santana
Copy link
Collaborator

Description

This is an initial commit to the experimental branch containing a first pass of work towards operator support in C++

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 15, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

sacpis
sacpis approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@sacpis sacpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if all tests are running successfully.

@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 2b42628 to 8150d70 Compare January 16, 2025 22:10
@sacpis sacpis force-pushed the dynamics_cpp_operators branch 4 times, most recently from bbec3ed to 5b14fad Compare January 28, 2025 00:12
@sacpis sacpis force-pushed the dynamics_cpp_operators branch 5 times, most recently from 3e3909f to 8c91e88 Compare February 4, 2025 21:49
@sacpis sacpis force-pushed the dynamics_cpp_operators branch 3 times, most recently from bc0cc73 to 90972a6 Compare February 7, 2025 21:48
sacpis added 10 commits February 10, 2025 08:07
@sacpis
Fixing the matrix in the unittest and other code in compute_lindblad …
a4c104a 
…apart for temp vector

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Adding cudm_state with unittests
11c7b65 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Addign few more unit tests for cudm_state
40e52d9 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Adding an enum with initial quantum state and initilize_state based o…
4ea6415 
…n InitialStateArgT

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Fixing spelling
31709a4 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
* Renaming cudm_mat_state -> cudm_state
dafc31a 
* Adding create_initial_state method to create initial state based on
  the passed InitialStateArgT

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Exposing state's rawData to be used in the stepper
e51696a 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Adding cudm_time_stepper with unittests
8a0bd3a 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Refactoring time_stepper compute method to align with cuquantum workflow
d2e0441 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Exposing handle and adding operator overloading for + and *
67d658b 
Signed-off-by: Sachin Pisal <[email protected]>
sacpis and others added 30 commits February 25, 2025 15:57
@sacpis
Bringing in Bettina's changes and formatting
184127d 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
* Separating evolve API for Python and C++
0bbb1eb 
* Adding CUDAQ DYNAMICS target check
* Formatting

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Cleaning up unwanted cudm_op_conversion
1e50360 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Adding libcudensitymat as the public link lib
c168b32 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Using PascalCase for classes, camel for methods, and snake_case for p…
ba31a9e 
…ublic APIs

Signed-off-by: Sachin Pisal <[email protected]>
@bettinaheim @sacpis
trivial implementation of anti-commutation relations (needs clean up)
00a991e 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
simplifying fermion operator handler since we don't use negative op c…
79871e6 
…odes

Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
test boson commutation relation
207cae5 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
introducing a more general notion of 'commutation sets'
88841c2 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
template specialization to avoid unnecessary overhead and some explan…
1c012a7 
…ations in comments

Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
properly allowing to customize commutation behavior - should allow fo…
85795d3 
…r e.g. quasiparticles and composite systems with two kinds of fermions that mutually commute

Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
review comments
3cc7d83 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
formatting
098bb2f 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
adding a quick check that fermion commutation relation with number op…
25939d9 
…erator works

Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
formatting
5ad29f9 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
spelling
09b9253 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
one more formatting fix
8a340b0 
Signed-off-by: Bettina Heim <[email protected]>
@sacpis
Cleaning up and adding missing code in schedule
d6c268b 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Adding comments
2861144 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Making comments consistent with othe rclasses
ff0e6bb 
Signed-off-by: Sachin Pisal <[email protected]>
@1tnguyen
Add a missing evolve_async overload
794e0d1 
Signed-off-by: Thien Nguyen <[email protected]>
@sacpis
Adding default copy assignment operator
92f9939 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Merge remote-tracking branch 'origin/dynamics_cpp_operators' into dyn…
97b55cb 
…amics_cpp_operators
@sacpis
Adding begin and end which returns an iterator to iterate schedule in…
cedbb48 
… a loop

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Adding explicit copy operator, added return type for begin and end it…
b8da9d9 
…erator methods, using shared_ptr for the integrator

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Adding default constructor to ensure m_schedule is properly initialized
6433ed4 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Adding comments, renaming, formatting
5fd3eb0 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Few more comments
2939d64 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Renaming unittests
d2bbf9c 
Signed-off-by: Sachin Pisal <[email protected]>
@1tnguyen
Tidy up evolve.h: make type conversion helpers
28566d5 
Signed-off-by: Thien Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bettinaheim bettinaheim Awaiting requested review from bettinaheim bettinaheim is a code owner

@1tnguyen 1tnguyen Awaiting requested review from 1tnguyen 1tnguyen is a code owner

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23 bmhowe23 is a code owner

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi schweitzpgi is a code owner

@sacpis sacpis Awaiting requested review from sacpis

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anthony-santana @sacpis @bettinaheim @1tnguyen