Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to bake in
fp8_model_init
into layer initialization.The
fp8_model_init
context manager needs to be then added/managed by the user. Baking it into TE layer initialization would allow that in addition to being just an argument.When trying to integrate with larger code bases like megatron or HF accelerate, we just need to pass the argument otherwise we'll have to figure out a place to add this context manager. So theoretically, this would result less code change.
One thing I'm not sure about is if calling fp8_model_init per layer is fine.
(Another though: could this potentially also allow selectively controlling to which layer to apply fp8 weights and is that helpful?)
@ptrendx @timmoon10 @ksivaman, do you think this makes sense?