-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pyproject.toml to specify build requirements #1061
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
/te-ci |
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modernizing to use pyproject.toml
would be nice for multiple reasons, but it will probably break user workflows (see #981 (comment)). In particular, pip install .
will no longer work and users will need to add the ---no-build-isolation
flag. It may be worthwhile, but we should be aware.
|
||
|
||
def uninstall_te_fw_packages(): | ||
subprocess.check_call( | ||
subprocess.run( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check_call
is nice since it will print out the error message if the process fails:
subprocess.run( | |
subprocess.check_call( |
We could alternatively call with check=True
or manually check the return code.
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
pyproject.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a section for the black formatter in pyproject.toml
to declare the following arguments? It's useful when we want to format the code locally.
TransformerEngine/.pre-commit-config.yaml
Line 31 in a326e35
args: [--line-length=100, --preview, --enable-unstable-feature=string_processing] |
Description
setup_requires
is deprecated (pep ref) and will be removed insetuptools
v75.0.0. This PR uses the newerpyproject.toml
to specify build time dependencies. We can consider gradually moving over other functionality topyproject.toml
as required.Type of change
Changes
Please list the changes introduced in this PR:
Checklist: