fix: Fix FMHA-based MLA in the generation phase and add MLA unit test #3863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinyangyuan-nvidia
requested review from
bobboli,
EmmaQiaoCh,
PerkzZheng,
peaceh-nv and
DylanChen-NV
|
/bot run |
|
PR_Github #3382 [ run ] triggered by Bot |
|
PR_Github #3382 [ run ] completed with state |
jinyangyuan-nvidia
force-pushed
the
dev/chore_mla_ut
branch
from
9e12a4c to
8befdc7
Compare
Signed-off-by: Perkz Zheng <[email protected]>
Signed-off-by: peaceh <[email protected]>
Signed-off-by: Dylan Chen <[email protected]>
Signed-off-by: Dylan Chen <[email protected]>
Signed-off-by: Jinyang Yuan <[email protected]>
jinyangyuan-nvidia
force-pushed
the
dev/chore_mla_ut
branch
from
8befdc7 to
bd144b7
Compare
|
/bot run |
|
PR_Github #3399 [ run ] triggered by Bot |
|
PR_Github #3399 [ run ] completed with state |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PerkzZheng fixes a bug of FMHA-based MLA in the generation phase.
@peaceh-nv modifies the code for SM120.
@jinyangyuan-nvidia adds MLA unit test.
This PR also cherry-picks the modifications in #3675.