fix(supervisor): preserve standard sbin paths in sandbox shells - #2846
Open
elezar wants to merge 3 commits into
Open
fix(supervisor): preserve standard sbin paths in sandbox shells#2846elezar wants to merge 3 commits into
elezar wants to merge 3 commits into
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
August 20, 2026 18:58
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve standard sbin directories in supervisor-launched sandbox child shells when CDI exposes tools such as
/usr/sbin/nvidia-smion Orin systems.Related Issue
No issue required: small localized regression fix discovered while validating stacked PR #2265 on an Orin Docker GPU gateway.
Changes
/usr/local/sbin,/usr/sbin, and/sbin./usr/sbin/nvidia-smi..bashrcrepair only when the CDI/policy gate is active.-centrypoints and SSH exec/login-shell commands only when the CDI/policy gate is active.PATHvalues on both entrypoint and SSH execution paths only when the CDI/policy gate is active.Testing
mise x -- cargo test -p openshell-supervisor-process standard_sbinmise x -- cargo test -p openshell-supervisor-process startup_snippetmise x -- cargo test -p openshell-supervisor-process symlinkmise x -- cargo test -p openshell-supervisor-process inject_provider_envmise x -- cargo test -p openshell-supervisor-process apply_child_envmise x -- cargo clippy -p openshell-supervisor-process --all-targets -- -D warningsPREBUILT_ARCH=arm64 bash tasks/scripts/stage-prebuilt-binaries.sh supervisor-outputPATHincludes/usr/sbin,command -v nvidia-smiresolves/usr/sbin/nvidia-smi, andnvidia-smi -Lreports the Orin GPUPATH=/sandbox/.venv/bin:/usr/local/bin:/usr/bin:/bin, confirming the CDI gate leaves ordinary sandboxes untouchedmise run pre-commitpassespostgresql, and workspace Rust lint hits a stalesqlx_macrosartifact requiringGLIBC_2.39.Checklist