-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(sandbox): add canonical main process #2726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
54d1045
feat(sandbox): add canonical main process
drew 4f1ee6f
feat(sandbox): simplify canonical main process contract
drew 13a68a6
fix(sandbox): preserve legacy VM main compatibility
drew 9d15c3a
fix(sandbox): preserve main status across driver updates
drew c07d8b5
fix(sandbox): satisfy macOS process lint
drew 5a28146
fix(sandbox): gate Linux exit acknowledgement publisher
drew a209b62
refactor(sandbox): simplify main process plumbing
drew 8dde92e
fix(supervisor): make controlling tty ioctl portable
drew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for a potential stupid question, but why does the cli reference needs to be manifested within a skill ? Wouldn't it be better to always rely on the current code at hand instead of constantly updating this files, which, if forgotten sometimes, might easily rot ? I'm not sure why a second source of truth is required. (i understand the token-saving concern to keep some kind of memory, but I believe the cost of a dealing with a split-brain is higher. No prove though).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pimlock maybe you can answer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will go away soon, here's related issue: #2736 (cc @johnnygreco)
Some extra context from a thread on this particular concern (not included in the ticket):
Also on the CLI reference, I wonder if there is a pattern of something like:
This way the reference and the skill is in sync, otherwise you may get a reference that has commands your CLI doesn't support, or vice versa.
@johnnygreco
Yes, I like that! That's actually how the Data Designer skill works. It has a step that says:
Agents seem to like it.