Skip to content

Conversation

thepatrickchin
Copy link
Contributor

@thepatrickchin thepatrickchin commented Sep 10, 2025

Description

  • Captures weave call ID for parent trace when workflow is initiated and embeds __TRACE_ID__ in assistant messages
  • __TRACE_ID__ is extracted in frontend – when user clicks like/dislike button, API call triggers Weave SDK to set reaction
    for the corresponding trace in Weave.
  • Requires addition of feedback endpoint in workflow config that invokes chat_feedback tool

See corresponding PR for frontend implementation NVIDIA/NeMo-Agent-Toolkit-UI#42

Closes #759

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Added functionality to store the workflow call ID in the context for later retrieval when a FUNCTION_START event is detected.

Signed-off-by: Patrick Chin <[email protected]>
Copy link

copy-pr-bot bot commented Sep 10, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link

coderabbitai bot commented Sep 10, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feedback buttons that integrate with observability tools
1 participant