Fix two small problems #291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did not include additional special tokens.
hyoo
referenced
this pull request
in hyoo/Megatron-DeepSpeed
Apr 21, 2023
* [QOL] Log the nodelist. * Tweak. * Tweak * Tweak. * lint
|
Marking as stale. No activity in 60 days. Remove stale label or comment or this will be closed in 7 days. |
|
No activity on stale PR in 21 days. |
|
Marking as stale. No activity in 60 days. |
rraminen
pushed a commit
to rraminen/Megatron-LM
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems:
This PR fixes these issues. Since the changes are so small, I didn't bother creating separate PRs but please tell me if you need it separate.