Skip to content

Remove thunder from default executors#6021

Open
Priya2698 wants to merge 1 commit intomainfrom
pm/thunder_benchmarks
Open

Remove thunder from default executors#6021
Priya2698 wants to merge 1 commit intomainfrom
pm/thunder_benchmarks

Conversation

@Priya2698
Copy link
Collaborator

No description provided.

@Priya2698 Priya2698 requested a review from naoyam February 28, 2026 00:05
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 28, 2026

Greptile Summary

Removed thunder from the DEFAULT_EXECUTORS list in benchmarks/python/core.py, reducing the default benchmark executors from ["eager", "torchcompile", "thunder"] to ["eager", "torchcompile"].

  • This affects all benchmark tests that use @pytest.mark.parametrize("executor", DEFAULT_EXECUTORS) - they will no longer automatically run with the thunder executor
  • All thunder functionality remains intact (imports, with_executor function still supports "thunder" and "thunder-torchcompile")
  • Thunder can still be used explicitly when needed

The change is clean, focused, and maintains backward compatibility for explicit thunder usage.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Single-line configuration change that removes thunder from default executors while preserving all functionality. No logic changes, no breaking changes, and all thunder support remains available for explicit use.
  • No files require special attention

Important Files Changed

Filename Overview
benchmarks/python/core.py Removed thunder from DEFAULT_EXECUTORS list while preserving all thunder functionality for explicit use

Last reviewed commit: 35e76dd

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant