-
Notifications
You must be signed in to change notification settings - Fork 78
Add NIXL backend #6016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
x41lakazam
wants to merge
10
commits into
main
Choose a base branch
from
dispatch_combine/nixl_backend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,105
−2
Draft
Add NIXL backend #6016
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cf77bdb
first working dispatch and combine primitive for k=1
samnordmann 66e7811
add comments and cleanup
samnordmann dda9aa7
add kernel based a2av and cuda backend for d/c
samnordmann 7aa2de8
unstable - add nixl backend
x41lakazam 9a8a377
unstable
x41lakazam 0f21528
add python build changes for nixl
x41lakazam 6144827
fix typo
x41lakazam 04a9133
merge main
x41lakazam b32587a
restore main:
x41lakazam f8a94fc
fix bug where zero-length buffer was passed to nixl
x41lakazam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,9 @@ | |
| #include <ATen/core/ivalue.h> | ||
| #include <c10/util/intrusive_ptr.h> | ||
|
|
||
| #include <cstdint> | ||
| #include <cstring> | ||
|
|
||
| #ifdef NVFUSER_DISTRIBUTED | ||
| #include <torch/csrc/distributed/c10d/Backend.hpp> | ||
| #include <torch/csrc/distributed/c10d/TCPStore.hpp> | ||
|
|
@@ -116,13 +119,20 @@ class NVF_API Communicator { | |
| return ucc_available_; | ||
| } else if (backend == CommunicatorBackend::kNccl) { | ||
| return nccl_available_; | ||
| } else if (backend == CommunicatorBackend::kNixl) { | ||
| #ifdef USE_NIXL | ||
| return true; | ||
| #else | ||
| return false; | ||
| #endif | ||
|
Comment on lines
+123
to
+127
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The logic LGTM but for consistency in the implementation please mimick what is done with |
||
| } | ||
| return false; | ||
| } | ||
|
|
||
| c10d::TCPStore* getTcpStore() { | ||
| return store_.get(); | ||
| } | ||
| } | ||
|
|
||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. blank line here and below |
||
| private: | ||
| Communicator( | ||
|
|
@@ -155,4 +165,5 @@ class NVF_API Communicator { | |
| std::unordered_map<std::string, c10::intrusive_ptr<c10d::Backend>> backends_; | ||
| }; | ||
|
|
||
|
|
||
| } // namespace nvfuser | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed