chore(studio): remove 11 unused TSX components#481
Open
marcusds wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (11)
💤 Files with no reviewable changes (11)
📝 WalkthroughWalkthroughThis PR removes several legacy Studio UI modules, including evaluation result download and filter components, fileset filter controls, and shared loader, avatar, action menu, and tool helper code. ChangesStudio UI cleanup
Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
marcusds
force-pushed
the
cleanup-unused-components/mschwab
branch
from
cf915cd to
4256617
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (2)
plugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/references/eval_helpers.py (1)
25-25: 📐 Maintainability & Code Quality | 🔵 TrivialRemove postponed annotations.
from __future__ import annotationsmakes every type hint string-backed at runtime and conflicts with the Python typing guideline to prefer concrete type hints.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/references/eval_helpers.py` at line 25, Remove the postponed-annotations import from eval_helpers.py; the module currently uses from __future__ import annotations, which makes all hints string-based at runtime. Update the file so its type hints remain concrete, and verify any affected annotations in eval_helpers or related helpers still work without relying on postponed evaluation.Source: Coding guidelines
plugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/SKILL.md (1)
587-701: 📐 Maintainability & Code Quality | 🔵 Trivial | 🏗️ Heavy liftTrim the eval walkthrough from
SKILL.md.This duplicates
references/post-training-eval.mdand makes the top-level skill harder to scan. Keep the skill as the execution entrypoint and leave the routing tables, examples, and report templates in the linked reference file.Based on learnings, "SKILL.md files under
.../skills/*/SKILL.mdare agent skill execution definitions, not rendered documentation pages. Keep the top-levelSKILL.mdconcise and move detailed reference material into separate linked files when useful."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/SKILL.md` around lines 587 - 701, The SKILL.md content is too detailed and duplicates the eval walkthrough already in references/post-training-eval.md; trim this file so it stays an execution entrypoint. Keep only the high-level routing decision, the two output-type branches, and brief pointers to the linked reference/doc sections, while removing the full tables, examples, and report template text from this skill. Preserve the existing symbols and structure around the “Using the output (`completed` only)”, “Using the adapter”, and “Using the fine-tuned model” sections, but replace the long walkthrough with concise guidance that points to the reference file.Source: Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@plugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/references/eval_helpers.py`:
- Around line 637-649: The routing metadata in the adapter loop is being rebuilt
from a fresh provider lookup instead of using the already collected eval
results. Update the routing construction in the eval helper to source each entry
from the matching EvalSummary values, using gateway_url, gateway_path, and
model_name for each adapter_name rather than calling build_platform_model_target
again.
- Around line 301-304: The completed-job filtering in eval_helpers.py is using
substring checks on job model/dataset refs, which can match unrelated entries
like default/qwen and default/qwen2. Update the filtering logic around the
job_model/job_ds checks to normalize both refs first and then compare exact
values instead of using "in" on their string forms. Keep the change localized to
the job selection path that processes model_ref and dataset_ref so only exact
matches are returned.
- Around line 201-212: The provider resolver currently matches both the base
entity and adapter-backed served models, which can auto-select a base-only
provider for LoRA evals. Update the discovery logic in the resolver used by the
eval helpers to require an explicit provider when the request targets an
adapter, or otherwise restrict matching to providers that are known to serve the
requested adapter/LoRA-enabled deployments. Make sure the matching and fallback
behavior in the resolver path that scans payload data and returns the selected
provider does not treat base-only providers as valid for adapter requests.
- Around line 57-80: The CHAT row validator currently checks only message shape
and roles, but it still allows non-object rows and turns missing valid string
content. Update assert_chat_row and _assert_message_turn to reject rows that are
not dicts and to verify each turn has a string content field before accepting
it, especially for messages[0] and messages[-1], so invalid input is caught
before reference_content/templates use it.
---
Nitpick comments:
In
`@plugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/references/eval_helpers.py`:
- Line 25: Remove the postponed-annotations import from eval_helpers.py; the
module currently uses from __future__ import annotations, which makes all hints
string-based at runtime. Update the file so its type hints remain concrete, and
verify any affected annotations in eval_helpers or related helpers still work
without relying on postponed evaluation.
In `@plugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/SKILL.md`:
- Around line 587-701: The SKILL.md content is too detailed and duplicates the
eval walkthrough already in references/post-training-eval.md; trim this file so
it stays an execution entrypoint. Keep only the high-level routing decision, the
two output-type branches, and brief pointers to the linked reference/doc
sections, while removing the full tables, examples, and report template text
from this skill. Preserve the existing symbols and structure around the “Using
the output (`completed` only)”, “Using the adapter”, and “Using the fine-tuned
model” sections, but replace the long walkthrough with concise guidance that
points to the reference file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7f581f48-ed8b-44b2-aca2-7c7fe808a131
📒 Files selected for processing (20)
plugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/SKILL.mdplugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/references/dataset-formats.mdplugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/references/eval_helpers.pyplugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/references/hyperparameters.mdplugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/references/integrations-setup.mdplugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/references/post-training-eval.mdplugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/references/troubleshooting.mdplugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/scripts/poll_customization_job.shplugins/nemo-customizer/tests/test_eval_helpers.pyweb/packages/studio/src/api/evaluation/details/useEvaluationDownloadResultsById.tsxweb/packages/studio/src/components/common/Loader.tsxweb/packages/studio/src/components/dataViews/SafeSynthesizerJobsDataView/Empty.tsxweb/packages/studio/src/components/evaluation/AvatarColorText.tsxweb/packages/studio/src/components/evaluation/Configurations/ActionMenu.tsxweb/packages/studio/src/components/evaluation/Jobs/TestMetric/ResultsLog.tsxweb/packages/studio/src/constants/tools.tsxweb/packages/studio/src/routes/FilesetListRoute/components/FilterPanel.tsxweb/packages/studio/src/routes/FilesetListRoute/components/FilterTags.tsxweb/packages/studio/src/routes/evaluation/EvaluationResultsRoute/FilterPanel.tsxweb/packages/studio/src/routes/evaluation/EvaluationResultsRoute/FilterTags.tsx
💤 Files with no reviewable changes (11)
- web/packages/studio/src/components/evaluation/AvatarColorText.tsx
- web/packages/studio/src/components/evaluation/Configurations/ActionMenu.tsx
- web/packages/studio/src/components/common/Loader.tsx
- web/packages/studio/src/components/dataViews/SafeSynthesizerJobsDataView/Empty.tsx
- web/packages/studio/src/api/evaluation/details/useEvaluationDownloadResultsById.tsx
- web/packages/studio/src/components/evaluation/Jobs/TestMetric/ResultsLog.tsx
- web/packages/studio/src/routes/evaluation/EvaluationResultsRoute/FilterPanel.tsx
- web/packages/studio/src/constants/tools.tsx
- web/packages/studio/src/routes/evaluation/EvaluationResultsRoute/FilterTags.tsx
- web/packages/studio/src/routes/FilesetListRoute/components/FilterPanel.tsx
- web/packages/studio/src/routes/FilesetListRoute/components/FilterTags.tsx
✅ Files skipped from review due to trivial changes (1)
- plugins/nemo-customizer/src/nemo_customizer/skills/nemo-customizer/scripts/poll_customization_job.sh
Contributor
|
marcusds
force-pushed
the
cleanup-unused-components/mschwab
branch
from
4256617 to
c87980b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 11 unused TSX components from
web/packages/studioto reduce code clutter and improve maintainability.Files removed
web/packages/studio/src/api/evaluation/details/useEvaluationDownloadResultsById.tsxweb/packages/studio/src/components/common/Loader.tsxweb/packages/studio/src/components/dataViews/SafeSynthesizerJobsDataView/Empty.tsxweb/packages/studio/src/components/evaluation/AvatarColorText.tsxweb/packages/studio/src/components/evaluation/Configurations/ActionMenu.tsxweb/packages/studio/src/components/evaluation/Jobs/TestMetric/ResultsLog.tsxweb/packages/studio/src/constants/tools.tsxweb/packages/studio/src/routes/FilesetListRoute/components/FilterPanel.tsxweb/packages/studio/src/routes/FilesetListRoute/components/FilterTags.tsxweb/packages/studio/src/routes/evaluation/EvaluationResultsRoute/FilterPanel.tsxweb/packages/studio/src/routes/evaluation/EvaluationResultsRoute/FilterTags.tsxSummary by CodeRabbit