fix: update customizer docs based on QA feedback#478
Conversation
|
🌿 Preview your docs: https://nvidia-preview-cust-docs-fixes-mck.docs.buildwithfern.com/nemo-platform |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughDocs and notebook examples were updated for embedding naming, SDK-based import and fine-tuning flows, completions-based evaluation calls, adapter API names, and throughput install snippets. Tutorial index copy was also corrected. ChangesCustomizer documentation updates
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/customizer/tutorials/import-hf-model.mdx`:
- Around line 167-169: The change to base_model.spec.linear_layers is only
applied to the local response object and will not affect the LoRA job that uses
default/{base_model.name}; update the actual model record instead. In the
tutorial flow around base_model.spec and client.models.update(...), persist the
spec change through the client before proceeding, or remove this local mutation
if it is not meant to be saved.
In `@docs/customizer/tutorials/understand-configurations-and-models.mdx`:
- Around line 189-195: The tutorial is still using the old nested adapter
methods instead of the published adapter APIs. Update the examples in this
document to use client.models.update_adapter(adapter_name=...) in place of
client.models.adapters.update, and client.models.create_adapter(name=...) in
place of client.models.adapters.create, keeping the surrounding parameters and
behavior the same. Use the client.models.adapters and client.models symbols to
find every affected snippet in this tutorial and replace them consistently.
In `@docs/fern/components/notebooks/optimize-throughput.json`:
- Around line 36-38: The notebook export is hardcoding all code cells as Python,
which causes shell cells like the one in optimize-throughput to be mislabeled.
Update `docs/fern/scripts/ipynb-to-fern-json.py` so it preserves each cell’s
source language when generating the `language` field, using the notebook cell
metadata for the shellscript cell and keeping Python only for actual Python
cells. Make sure the export logic that builds the JSON for notebook cells
carries this language through into
`docs/fern/components/notebooks/optimize-throughput.json`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: ad42ea1c-58d6-4e87-ba77-9b73f98a4798
📒 Files selected for processing (16)
docs/customizer/models/embedding.mdxdocs/customizer/tutorials/embedding-customization-job.ipynbdocs/customizer/tutorials/embedding-customization-job.mdxdocs/customizer/tutorials/import-hf-model.mdxdocs/customizer/tutorials/index.mdxdocs/customizer/tutorials/optimize-throughput.ipynbdocs/customizer/tutorials/optimize-throughput.mdxdocs/customizer/tutorials/sft-customization-job.ipynbdocs/customizer/tutorials/sft-customization-job.mdxdocs/customizer/tutorials/understand-configurations-and-models.mdxdocs/fern/components/notebooks/embedding-customization-job.jsondocs/fern/components/notebooks/embedding-customization-job.tsdocs/fern/components/notebooks/optimize-throughput.jsondocs/fern/components/notebooks/optimize-throughput.tsdocs/fern/components/notebooks/sft-customization-job.jsondocs/fern/components/notebooks/sft-customization-job.ts
💤 Files with no reviewable changes (2)
- docs/customizer/tutorials/optimize-throughput.mdx
- docs/customizer/tutorials/optimize-throughput.ipynb
|
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
b40c329 to
ec38fe9
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/customizer/tutorials/import-hf-model.mdx`:
- Around line 149-151: The ConflictError branch in the HuggingFace import flow
currently only retrieves the existing fileset, which leaves its stored config
stale across reruns. Update the logic in the exception handler around MODEL_NAME
to modify the existing fileset instead of just calling
client.files.filesets.retrieve, so any changed HuggingFace settings like repo_id
or token_secret are written back consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7a051992-b470-4301-b57d-66aa3fc30774
📒 Files selected for processing (16)
docs/customizer/models/embedding.mdxdocs/customizer/tutorials/embedding-customization-job.ipynbdocs/customizer/tutorials/embedding-customization-job.mdxdocs/customizer/tutorials/import-hf-model.mdxdocs/customizer/tutorials/index.mdxdocs/customizer/tutorials/optimize-throughput.ipynbdocs/customizer/tutorials/optimize-throughput.mdxdocs/customizer/tutorials/sft-customization-job.ipynbdocs/customizer/tutorials/sft-customization-job.mdxdocs/customizer/tutorials/understand-configurations-and-models.mdxdocs/fern/components/notebooks/embedding-customization-job.jsondocs/fern/components/notebooks/embedding-customization-job.tsdocs/fern/components/notebooks/optimize-throughput.jsondocs/fern/components/notebooks/optimize-throughput.tsdocs/fern/components/notebooks/sft-customization-job.jsondocs/fern/components/notebooks/sft-customization-job.ts
💤 Files with no reviewable changes (2)
- docs/customizer/tutorials/optimize-throughput.mdx
- docs/customizer/tutorials/optimize-throughput.ipynb
✅ Files skipped from review due to trivial changes (5)
- docs/customizer/tutorials/index.mdx
- docs/customizer/models/embedding.mdx
- docs/customizer/tutorials/embedding-customization-job.ipynb
- docs/customizer/tutorials/understand-configurations-and-models.mdx
- docs/customizer/tutorials/embedding-customization-job.mdx
🚧 Files skipped from review as they are similar to previous changes (8)
- docs/customizer/tutorials/sft-customization-job.ipynb
- docs/fern/components/notebooks/sft-customization-job.ts
- docs/customizer/tutorials/sft-customization-job.mdx
- docs/fern/components/notebooks/embedding-customization-job.ts
- docs/fern/components/notebooks/optimize-throughput.json
- docs/fern/components/notebooks/embedding-customization-job.json
- docs/fern/components/notebooks/optimize-throughput.ts
- docs/fern/components/notebooks/sft-customization-job.json
Co-authored-by: Albert Cui <albcui@nvidia.com> Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
f99d4d6 to
1ab9baa
Compare
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
Summary by CodeRabbit
nvidia/llama-nemotron-embed-1b-v2.training.finetuning_typeto"lora_merged"; unmerged LoRA adapters aren’t supported (ONNX requirement).v1/completionsusingprompt, and adjusted output parsing accordingly.%%bashdirectives from relevant notebook dependency-install cells.