fix: read beam.search_type from config instead of hardcoding 'default'#15402
Open
nedalaltiti wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Open
fix: read beam.search_type from config instead of hardcoding 'default'#15402nedalaltiti wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
nedalaltiti wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: nedalaltiti <nedal.altiti@live.com>
02531a5 to
07f049f
Compare
Author
|
Hi @nithinraok, could you please add the Run CICD label to trigger the CI tests? Also requesting your review on this ASR fix. Note: The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Fixes CTC beam decoding configuration by reading
beam.search_typefrom the decoding config instead of hardcodingsearch_type="default"whenstrategy="beam"inAbstractCTCDecoding.__init__.This enables intended behavior for LM-aware beam search backends (e.g.,
pyctcdecode) when users setbeam.search_typeand providekenlm_path.Collection: [ASR]
Changelog
Update
AbstractCTCDecoding.__init__to pass:search_type="default"search_type=self.cfg.beam.get("search_type", "default")Keeps backward compatibility via the
"default"fallback whenbeam.search_typeis not set.Usage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
PR Type:
Additional Information
Diff summary:
search_type="default"search_type=self.cfg.beam.get("search_type", "default")Reviewer: @nithinraok