Compatibility with inference other than vllm < 0.10.2#700
Open
tdene wants to merge 2 commits intoNVIDIA-NeMo:mainfrom
Open
Compatibility with inference other than vllm < 0.10.2#700tdene wants to merge 2 commits intoNVIDIA-NeMo:mainfrom
tdene wants to merge 2 commits intoNVIDIA-NeMo:mainfrom
Conversation
tdene
force-pushed
the
tde/new_vllm_compat
branch
from
9d30e72 to
94afba2
Compare
Signed-off-by: Teodor-Dumitru Ene <tene@nvidia.com>
tdene
force-pushed
the
tde/new_vllm_compat
branch
from
94afba2 to
111ef6b
Compare
Signed-off-by: Teodor-Dumitru Ene <tene@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside
vllm_model/app.py, there is a comment bloc that says:The associated code always assumes that the user is using vLLM < 0.10.2. This removes that assumption, allowing NeMo Gym to work easily with vLLM >= 0.10.2 or any other inference framework.