Skip to content

docs(embeddings): fix links, model names, and search interface#1641

Open
Pouyanpi wants to merge 2 commits intodevelopfrom
docs/configure-rails-other-configurations
Open

docs(embeddings): fix links, model names, and search interface#1641
Pouyanpi wants to merge 2 commits intodevelopfrom
docs/configure-rails-other-configurations

Conversation

@Pouyanpi
Copy link
Collaborator

Description

  • Fix broken links to guardrails process and knowledge base docs
  • Update text-embedding-ada-002 to text-embedding-3-small
  • Add threshold parameter to EmbeddingsIndex.search signature

- Fix broken links to guardrails process and knowledge base docs
- Update text-embedding-ada-002 to text-embedding-3-small
- Add threshold parameter to EmbeddingsIndex.search signature
@Pouyanpi Pouyanpi added this to the v0.21 milestone Feb 16, 2026
@Pouyanpi Pouyanpi requested a review from miyoungc February 16, 2026 11:27
@Pouyanpi Pouyanpi added the documentation Improvements or additions to documentation label Feb 16, 2026
@github-actions
Copy link
Contributor

Documentation preview

https://nvidia-nemo.github.io/Guardrails/review/pr-1641

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 16, 2026

Greptile Summary

This PR fixes documentation in the embedding search providers guide:

  • Broken links fixed: Updates two broken links to ../../architecture/README.md#the-guardrails-process and ../configuration-guide.md#knowledge-base-documents that no longer exist, pointing them to the correct ../../reference/colang-architecture-guide.md#the-guardrails-process and knowledge-base.md respectively. Both new targets verified to exist.
  • Model name updated: Changes text-embedding-ada-002 to text-embedding-3-small in the OpenAI embedding examples, reflecting OpenAI's newer recommended model.
  • threshold parameter added to search interface: Adds threshold: Optional[float] = None to the documented EmbeddingsIndex.search signature, however the default value = None does not match the actual base class source code in nemoguardrails/embeddings/index.py:65, which has threshold: Optional[float] without a default.

Confidence Score: 4/5

  • Documentation-only change that is safe to merge; the link and model fixes are correct, with one minor inaccuracy in the interface signature.
  • This is a documentation-only PR with no runtime code changes. The broken link fixes and model name updates are verified correct. The only issue is a minor discrepancy between the documented EmbeddingsIndex.search signature (with = None default) and the actual base class source code (no default). This won't break anything but could confuse users implementing custom embedding providers.
  • docs/configure-rails/other-configurations/embedding-search-providers.md — the EmbeddingsIndex.search signature at line 127 has a default value mismatch with the actual source.

Important Files Changed

Filename Overview
docs/configure-rails/other-configurations/embedding-search-providers.md Documentation fixes for broken links, model name updates, and search interface. Links and model name changes are correct, but the threshold default value in the EmbeddingsIndex.search signature doesn't match the actual base class source code.

Class Diagram

classDiagram
    class EmbeddingsIndex {
        +embedding_size: int
        +cache_config
        +_get_embeddings(texts: List~str~)
        +add_item(item: IndexItem)
        +add_items(items: List~IndexItem~)
        +build()
        +search(text: str, max_results: int, threshold: Optional~float~) List~IndexItem~
    }
    class BasicEmbeddingsIndex {
        +search(text: str, max_results: int, threshold: Optional~float~ = None) List~IndexItem~
    }
    class IndexItem {
        +text: str
        +meta: Dict
    }
    EmbeddingsIndex <|-- BasicEmbeddingsIndex : extends
    EmbeddingsIndex ..> IndexItem : returns
    note for EmbeddingsIndex "Base class: threshold is REQUIRED\n(no default value)"
    note for BasicEmbeddingsIndex "Subclass: threshold defaults to None"
Loading

Last reviewed commit: dc49aca

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

…viders.md

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: Pouyan <13303554+Pouyanpi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments