Add support for stop_words in Ray MBridge deployment#605
Open
Add support for stop_words in Ray MBridge deployment#605
Conversation
Signed-off-by: Abhishree <abhishreetm@gmail.com>
Contributor
Author
|
/ok to test 7937894 |
Signed-off-by: Abhishree <abhishreetm@gmail.com>
Contributor
Author
|
/ok to test 1fedc31 |
oyilmaz-nvidia
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts stop_words from incoming request and exposes them in
nemo_deploy/llm/megatronllm_deployable_ray.pyandnemo_deploy/llm/megatronllm_deployable.pyto be passed along to the mcore inference engine. Helps reduce unnecessary token generation(which was the case before where a lot of unnecessary tokens were generated) beyond the stop_words passed in the incoming eval requests hence improving the speed.Speed improvement with 10% gsm8k eval on llama 3.2 1B:
Before stop_words support in deployment: 10 mins
After stop_words support in deployment: 4 min 37s