-
Notifications
You must be signed in to change notification settings - Fork 58
feat: add --save-results option to preview command #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3c9d7cc
feat: add --save-report option to preview command
johnnygreco ed560ab
feat: add save_path option to display_sample_record
johnnygreco 9fd3b36
feat: replace --save-report with --save-results on preview command
johnnygreco dba0e8c
feat: add sample records pager with theme toggle, postMessage bridge,β¦
johnnygreco 5a7b9da
feat: add dataset metadata subtitle to pager and clean up toolbar layout
johnnygreco 69c6f4f
fix: address review findings for preview save-results feature
johnnygreco 437963c
fix: address code review findings and simplify pager
johnnygreco e6fef53
style: move record counter to far right of pager toolbar
johnnygreco ad4c9b2
refactor: remove dead theme-listener script and inline CSS constant
johnnygreco 4f4bcd4
fix: move Path import out of TYPE_CHECKING block in test_visualization
johnnygreco e392f2e
fix: rename _logger to logger to match codebase convention
johnnygreco 4e02fd8
fix: remove unnecessary cast in preview command theme parameter
johnnygreco a32155c
refactor: extract DEFAULT_DISPLAY_WIDTH constant and make apply_html_β¦
johnnygreco 52245b7
Update packages/data-designer-config/tests/config/utils/test_visualizβ¦
johnnygreco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this flips the background to dark blue but Rich's default markup colors (greens, reds, dim text) were designed for white. they're not broken, but some of them feel a bit washed out on the dark bg. the dracula code blocks look great since that theme was made for dark β just something to keep an eye on if you want to polish the dark mode later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good callout! For sure would be a good idea to iterate once more folks have seen it on their screen