Bump pyasn1 due to cve GHSA-63vm-454h-vhhq for r1.1.0#1424
Closed
ayushdg wants to merge 1 commit intoNVIDIA-NeMo:r1.1.0from
Closed
Bump pyasn1 due to cve GHSA-63vm-454h-vhhq for r1.1.0#1424ayushdg wants to merge 1 commit intoNVIDIA-NeMo:r1.1.0from
ayushdg wants to merge 1 commit intoNVIDIA-NeMo:r1.1.0from
Conversation
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Contributor
|
No reviewable files after applying ignore patterns. |
Contributor
praateekmahajan
left a comment
praateekmahajan
left a comment
There was a problem hiding this comment.
shouldn't we add this bump in the constraints like the other CVEs?
Contributor
Author
Since this isn't a direct dependency but an indirect one coming from other packages I figured just bumping the uv lock file is sufficient. I'm not sure if that's the criteria. @thomasdhc Do you have thoughts? |
Contributor
|
IIUC that's what |
Contributor
|
pyasn1 is already constrained https://github.com/NVIDIA-NeMo/Curator/blob/r1.1.0/pyproject.toml#L186 |
Contributor
Author
|
Closing since it's already been updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Usage
# Add snippet demonstrating usageChecklist