Skip to content

heuristic page updates#1422

Merged
lbliii merged 11 commits intoNVIDIA-NeMo:mainfrom
lbliii:llane/scores-jsonl
Feb 2, 2026
Merged

heuristic page updates#1422
lbliii merged 11 commits intoNVIDIA-NeMo:mainfrom
lbliii:llane/scores-jsonl

Conversation

@lbliii
Copy link
Contributor

@lbliii lbliii commented Jan 23, 2026

No description provided.

Signed-off-by: Lawrence Lane <llane@nvidia.com>
@lbliii lbliii self-assigned this Jan 23, 2026
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@lbliii lbliii requested a review from sarahyurick January 23, 2026 18:10
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@sarahyurick sarahyurick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some minor requests.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Signed-off-by: Lawrence Lane <llane@nvidia.com>
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@lbliii lbliii requested a review from sarahyurick January 26, 2026 17:13
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Comment on lines 473 to 478
# Option 2: RayActorPoolExecutor - uses Ray Actor Pools
ray_actor_executor = RayActorPoolExecutor(
config={"ignore_failures": False},
ignore_head_node=True
)
results = pipeline.run(ray_actor_executor)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's only suggest playing with RayDataExecutor here, not RayActorPoolExecutor. The team has seen some real perf improvements for filtering when using RayDataExecutor instead of XennaExecutor.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Signed-off-by: Lawrence Lane <llane@nvidia.com>
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Signed-off-by: Lawrence Lane <llane@nvidia.com>
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@sarahyurick sarahyurick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lbliii lbliii enabled auto-merge (squash) February 2, 2026 16:30
@lbliii lbliii merged commit b524c15 into NVIDIA-NeMo:main Feb 2, 2026
18 checks passed
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants