Conversation
Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Greptile OverviewGreptile SummaryAdds a new GitHub Actions workflow for automated documentation releases to Akamai CDN via AWS S3, triggered manually with dry-run support and email notifications.
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant GHA as GitHub Actions
participant BuildJob as build-docs job
participant PublishJob as publish-docs job
participant FWCI as FW-CI-templates
participant AWS as AWS S3
participant Akamai as Akamai CDN
User->>GHA: Trigger workflow_dispatch<br/>(dry-run, version-number, notify-emails, aws-region)
GHA->>BuildJob: Start build-docs
BuildJob->>FWCI: Call _build_docs.yml@v0.67.0
FWCI-->>BuildJob: Build docs artifacts
BuildJob-->>GHA: Upload docs-html artifacts
GHA->>PublishJob: Start publish-docs (needs: build-docs)
PublishJob->>FWCI: Checkout FW-CI-templates@v0.67.2
PublishJob->>FWCI: Call publish-docs action
FWCI->>AWS: Upload docs to S3 (nemo/curator)
FWCI->>Akamai: Publish to CDN
FWCI-->>PublishJob: Send email notifications
PublishJob-->>GHA: Complete
GHA-->>User: Workflow complete
|
| uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_build_docs.yml@v0.67.0 | ||
|
|
||
| publish-docs: | ||
| runs-on: ubuntu-latest | ||
| needs: [build-docs] | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| repository: NVIDIA-NeMo/FW-CI-templates | ||
| ref: v0.67.2 |
There was a problem hiding this comment.
Version mismatch between reusable workflow (@v0.67.0 on line 39) and checkout ref (v0.67.2 on line 48). Should use the same version for consistency.
| uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_build_docs.yml@v0.67.0 | |
| publish-docs: | |
| runs-on: ubuntu-latest | |
| needs: [build-docs] | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| repository: NVIDIA-NeMo/FW-CI-templates | |
| ref: v0.67.2 | |
| build-docs: | |
| uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_build_docs.yml@v0.67.2 | |
| publish-docs: | |
| runs-on: ubuntu-latest | |
| needs: [build-docs] | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| repository: NVIDIA-NeMo/FW-CI-templates | |
| ref: v0.67.2 |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| version-number: | ||
| description: Version number to release this as (use `latest` for main branch) | ||
| required: true | ||
| type: string |
There was a problem hiding this comment.
version-number input is never used in the workflow. The version is determined automatically from the branch/tag name in the publish-docs action (line 63). Consider removing this unused input or documenting why it's defined but not used.
| on: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Consider adding explicit permissions declaration for security best practices. Since this workflow handles AWS/Akamai credentials, specify minimal required permissions.
Description
Add automation that releases docs
Usage
# Add snippet demonstrating usageChecklist