[benchmarking] Add Semantic Deduplication Identification#1410
Merged
praateekmahajan merged 11 commits intoNVIDIA-NeMo:mainfrom Jan 26, 2026
Merged
[benchmarking] Add Semantic Deduplication Identification#1410praateekmahajan merged 11 commits intoNVIDIA-NeMo:mainfrom
praateekmahajan merged 11 commits intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ayushdg
changed the title
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
[benchmarks] Update Semdedup benchmark + Add more metrics logging to KMeans + load_dataset_size accepts dataset ratio
Co-authored-by: Praateek Mahajan <praateekmahajan@users.noreply.github.com> Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+118
to
+122
| _kmeans_time_taken = kmeans_read_time + kmeans_write_time + kmeans_fit_predict_time | ||
|
|
||
| kmeans_read_percent_time = round((kmeans_read_time / _kmeans_time_taken) * 100, 2) | ||
| kmeans_write_percent_time = round((kmeans_write_time / _kmeans_time_taken) * 100, 2) | ||
| kmeans_fit_predict_percent_time = round((kmeans_fit_predict_time / _kmeans_time_taken) * 100, 2) |
Contributor
There was a problem hiding this comment.
division by zero if _kmeans_time_taken equals 0
If all three time metrics (kmeans_read_time, kmeans_write_time, kmeans_fit_predict_time) are 0, this will cause a division by zero error.
Suggested change
| _kmeans_time_taken = kmeans_read_time + kmeans_write_time + kmeans_fit_predict_time | |
| kmeans_read_percent_time = round((kmeans_read_time / _kmeans_time_taken) * 100, 2) | |
| kmeans_write_percent_time = round((kmeans_write_time / _kmeans_time_taken) * 100, 2) | |
| kmeans_fit_predict_percent_time = round((kmeans_fit_predict_time / _kmeans_time_taken) * 100, 2) | |
| _kmeans_time_taken = kmeans_read_time + kmeans_write_time + kmeans_fit_predict_time | |
| if _kmeans_time_taken > 0: | |
| kmeans_read_percent_time = round((kmeans_read_time / _kmeans_time_taken) * 100, 2) | |
| kmeans_write_percent_time = round((kmeans_write_time / _kmeans_time_taken) * 100, 2) | |
| kmeans_fit_predict_percent_time = round((kmeans_fit_predict_time / _kmeans_time_taken) * 100, 2) | |
| else: | |
| kmeans_read_percent_time = None | |
| kmeans_write_percent_time = None | |
| kmeans_fit_predict_percent_time = None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Usage
# Add snippet demonstrating usageChecklist