Open
Conversation
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Contributor
Author
|
/ok to test 0751476 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Resuming training of MoE LoRA or QLoRA models from a checkpoint causes a loss spike (back to random-init levels). The LoRA adapter weights are silently not loaded.
Root Cause
PyTorch DCP (
get_model_state_dict/set_model_state_dict) loading cannot handle:gate_up_linear.weight0) that DCP's FQN resolution cannot traverse →KeyErroron save, silent skip on load, i.e. the model weight is from scratch.Solution
Bypass DCP entirely for PEFT models with EP or quantization. All changes in
nemo_automodel/components/checkpoint/stateful_wrappers.py:_set_peft_state_dict()— matches saved tensors by name, redistributes full tensors back into EP DTensor shards.Test
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information