EDITOR-#620. Finish partially load frames of selected dancers/time range #628
Conversation
There was a problem hiding this comment.
Well done! But some minor changes required as I commented in the code, and little bugs to be fixed:
- Using the timeline frame jumper and time input users can jump to frames outside of the selected time interval, fix this in
core/actions/state/timeline.pyandset_time()incore/actions/property/timeline.py.
| bpy.context.scene.frame_start = 0 | ||
| bpy.context.scene.frame_end = bpy.context.scene.sequence_editor.sequences[ | ||
| 0 | ||
| ].frame_duration |
There was a problem hiding this comment.
Keep these, the users should be able to preview the time interval they are selecting, if you remove this part the frame interval will be locked to 1~250 before partial load.
There was a problem hiding this comment.
I want you to update context.scene.frame_{start,end} at update of these UI properties, so the users can preview the interval they're selecting before proceeding. (FYI, I'm planning to mark the start of scenes (幕) in another PR.)
| ) | ||
|
|
||
|
|
||
| def linear_interpolation(lval: float, ldist: int, rval: float, rdist: int): |
There was a problem hiding this comment.
Maybe move this to algorithm.py
| @@ -88,6 +93,7 @@ async def add_control_frame(): | |||
| set_requesting(False) | |||
|
|
|||
|
|
|||
| # TODO finish this function | |||
There was a problem hiding this comment.
You should remove those TODOs after finishing them, or they're going to accumulate in our repo.
| @@ -1,3 +1,5 @@ | |||
| from functools import reduce | |||
| @@ -195,6 +197,11 @@ def poll(cls, context: bpy.types.Context | None): | |||
| ) | |||
| return state.ready and ld_ui_led_editor.edit_part != "" | |||
|
|
|||
| elif state.editor == Editor.CONTROL_EDITOR: | |||
There was a problem hiding this comment.
You should do the same thing to the delete button in position and control
| class LoadPartialOperator(AsyncOperator): | ||
| bl_idname = "lightdance.load_partial" | ||
| bl_label = "Load frames in selected interval" | ||
| bl_label = "Load frames for selected dancers" | ||
| # bl_label = "Load frames in selected interval" | ||
|
|
||
| async def async_execute(self, context: bpy.types.Context): | ||
| # TODO |
There was a problem hiding this comment.
Remove this TODO comment since you already finished it
| import bpy | ||
| from bpy.types import Context, UILayout |
There was a problem hiding this comment.
I don't think this is necessary, using bpy types without bpy.* could be confusing IMO.
ExuberantIris
force-pushed
the
BLENDER-#620
branch
from
749b446 to
d9ca256
Compare
What is this PR for?
This Pull Request aims to add the feature of partially load frames of selected dancers/time range
What type of PR is it?
Feature
Todos
None.
What is the Github issue?
#620
How should this be tested?
Screenshots (if appropriate)
Questions