removed some PVs that are no longer in use for eiger2 detector; chang…#28
Merged
dihenriksen merged 1 commit intomainfrom Jan 16, 2026
Merged
removed some PVs that are no longer in use for eiger2 detector; chang…#28dihenriksen merged 1 commit intomainfrom
dihenriksen merged 1 commit intomainfrom
Conversation
…ed a couple strictenums to subsetenums
jwlodek
approved these changes
Jan 16, 2026
jwlodek
left a comment
jwlodek
left a comment
There was a problem hiding this comment.
Discovered when connecting Eiger ophyd-async object to real hardware. Eiger2 had some additional options for some of the enum PVs, and some of the Eiger1 PVs were no longer available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ed a couple strictenums to subsetenums