Conversation
|
How much should be refactoring code to fix the linting issues, and how much should be just excluding files from flake? A lot of the scripts don't seem like they were meant to be submodules but rather just profile scripts. Should I make/add them to a /scripts directory? |
Collaborator
|
Guys, recently I played with ChatGPT 4.0 for coding and found that it’s amazing and could save lots of our precious time. One can copy the current code and paste to gpt and it will give what you want, at least at some degrees. Hope this helps.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Thomas Morris ***@***.***>
Sent: Monday, May 6, 2024 2:32:48 PM
To: NSLS-II/pyCHX ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [NSLS-II/pyCHX] STY: enable `flake8` checks (PR #84)
How much should be refactoring code to fix the linting issues, and how much should be just excluding files from flake? A lot of the scripts don't seem like they were meant to be submodules but rather just profile scripts. Should I make/add them to a /scripts directory?
—
Reply to this email directly, view it on GitHub<#84 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACR3YGNUZADVIYYLHOOLP7DZA7EFBAVCNFSM6AAAAABHCVRA66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJWGY3DEMJZGA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
See #88, most of it was automated so testing is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we capture more potential issues.
Although, the number of flake8 errors is significant, many of them are repeating, such as: