Skip to content

Conversation

@MatthewPyle-NOAA
Copy link
Contributor

@MatthewPyle-NOAA MatthewPyle-NOAA commented Oct 24, 2025

DESCRIPTION OF CHANGES:

  • Updates the versions files to update many version numbers, and remove unneeded items.
    BUFR (11.7 --> 12.2)
    cray-mpich (8.1.12 --> 8.1.19)
    cray-pals (1.1.3 --> 1.3.2)
    craype (2.7.13 --> 2.7.17)
    crtm (2.4.0 --> 2.4.0.2)
    emsf (8.4.0 --> 8.8.0)
    g2 (3.4.5 --> 3.5.1)
    g2tmpl (1.15.0 --> 1.16.0, eventually will be 1.17.0)
    gftl_shared (1.5.0 --> 1.6.1 )
    ip (3.3.3 --> 5.2.0)
    landsfcutil, mapl, module, scotch (all removed)
    ncdiag (1.1.1 --> 1.1.2)
    nemsio (2.5.2 --> 2.5.4)
    adds pnetcdf (1.12.2)
    PrgEnv_Intel (8.1 --> 8.5)
    sp (2.3.3 --> 2.4.0)
    w3emc (2.9.2 --> 2.12.0)
    nco (5.0.6 --> 5.2.4)

  • Updates build and task module files to point at things like "netcdf-D", and new needs for HDF5 and/or pnetcdf (some based on testing, some speculative additions)

  • Points at a GSI fork with some small changes for BUFR/12.2

TESTS CONDUCTED:

  • Limited testing so far using the dev-sci non-DA tests. Does change answers a bit in this testing, and expect this will take significant testing to make sure we are comfortable with running it in the real-time parallel.

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A:
  • RRFS_B:
  • RTMA:
  • Others:

ISSUE:

CONTRIBUTORS (optional):

@Hang-Lei-NOAA provided some early help on getting this started. @JamesPolly-NCO provided other information on what is needed for production.

MatthewPyle-NOAA and others added 21 commits September 24, 2025 12:33
need hdf5-D, netcdf-D, and pnetcdf-D whenver netcdf is being invoked.

Left save_restart.local.lua alone - is using hard wired, somewhat older
libraries.  Will want to revisit when test this PR.
@MatthewPyle-NOAA MatthewPyle-NOAA marked this pull request as ready for review October 27, 2025 12:20
ShunLiu-NOAA
ShunLiu-NOAA previously approved these changes Oct 27, 2025
@lgannoaa
Copy link
Contributor

We have two main questions regarding this PR:

  1. Module Path Assignments
    Since the module path now points to the production area for module loading, can we remove the hardcoded development path assignments (modulepath_compiler, modulepath_mpi, and modulepath_scotch) from the run.var file?

  2. GSI Package Update (Hash dd35b93)
    The GSI hash has been updated to dd35b93. This raises a few concerns, given that we have informed management and NCO that the RRFS project is currently on science freeze:
    Is this update considered a science upgrade?
    Will this change impact the scientific results?
    What is the justification for updating the GSI package at this stage of the project?

@MatthewPyle-NOAA
Copy link
Contributor Author

@lgannoaa Things built okay after stripping out the modulepath definitions from build.ver, and associated use in the build modulefile. So do think we can clean that aspect up. On the GSI update, it isn't a science change. It is just allowing it to compile with BUFR/12.2. Want to do a simple run test before pushing an updated run.ver file.

GSI script to use CRTM_FIX provided by load of CRTM module.
@MatthewPyle-NOAA
Copy link
Contributor Author

Should be ready for another look now. Note @ShunLiu-NOAA that I made a change to the GSI ex-script as part of the cleanup.

lgannoaa
lgannoaa previously approved these changes Oct 27, 2025
Copy link
Contributor

@lgannoaa lgannoaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MatthewPyle-NOAA. It looks good to me.

@ShunLiu-NOAA
Copy link
Contributor

@MatthewPyle-NOAA the changes looks good to me.

Copy link
Contributor

@BenjaminBlake-NOAA BenjaminBlake-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatthewPyle-NOAA the modulefile changes look good to me. I'm happy to assist with generating some comparison graphics to better evaluate the differences once we have some output available.

@MatthewPyle-NOAA MatthewPyle-NOAA changed the title [main] Module update and cleanup [main] RRFS module update and cleanup Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants