Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more additional RR types #418

Merged
merged 13 commits into from
Jan 23, 2025
Merged

Some more additional RR types #418

merged 13 commits into from
Jan 23, 2025

Conversation

wtoorop
Copy link
Member

@wtoorop wtoorop commented Jan 3, 2025

Added support for DSYNC, EID, NIMLOC, SINK, TALINK, DOA, AMTRELAY and IPN RR types.

@wtoorop wtoorop marked this pull request as ready for review January 22, 2025 12:43
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The companion change for the simdzone additional RR types support. Nice to have the additional RR types support. They are all generic types, so this only provides zonefile syntax read and print. I am a bit uncomfortable with the reuse of the IPSECKEY gateway function for the new type AMTRELAY, because the 0x7f mask for the gateway type is not part of the IPSECKEY format.

@wtoorop
Copy link
Member Author

wtoorop commented Jan 23, 2025

The companion change for the simdzone additional RR types support. Nice to have the additional RR types support. They are all generic types, so this only provides zonefile syntax read and print. I am a bit uncomfortable with the reuse of the IPSECKEY gateway function for the new type AMTRELAY, because the 0x7f mask for the gateway type is not part of the IPSECKEY format.

Thanks, I agree. Last commit (4c456af) fixes just that.

As well as have the updated main branch from simdzone as submodule
@wtoorop wtoorop merged commit cb0ba44 into master Jan 23, 2025
6 of 7 checks passed
wtoorop added a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants