Skip to content

Conversation

@ClarksonAdam
Copy link
Contributor

@ClarksonAdam ClarksonAdam commented Jan 8, 2026

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-6224


📄 Description/Summary of Changes

  • Updated workflow to push successfully to the Sandbox and Integration Postman collections
  • Updated the workflow trigger to be called if the Postman collection files are updated on push to Master
  • Added description to the workflow to improve understanding
  • Refactored workflow to have a separate job for Integration and Sandbox
  • Removed unused variable from Sandbox Postman collection to resolve error on push

🧪 Developer Testing Carried Out


🧪 Reviewer Testing Required

  • Review workflow files
  • Run workflow via workflow dispatch if wanted

✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX/<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@ClarksonAdam ClarksonAdam self-assigned this Jan 8, 2026
@ClarksonAdam ClarksonAdam added github_actions Pull requests that update GitHub Actions code postman Changes to the postman collection labels Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6224

@ClarksonAdam ClarksonAdam merged commit da88184 into master Jan 8, 2026
19 of 20 checks passed
@ClarksonAdam ClarksonAdam deleted the poc/npa-6224/fix-to-postman-push-workflow branch January 8, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code postman Changes to the postman collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants