Skip to content

Conversation

@LeoKHoward
Copy link
Contributor

@LeoKHoward LeoKHoward commented Jan 7, 2026

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-6124


📄 Description/Summary of Changes

  • Added support for capturing free text notes when updating or creating a proxy role alongside existing status and reason code selection
  • Updated spec files
  • Updated sandbox code for relevant endpoints and added unit test scenarios

🧪 Developer Testing Carried Out


🧪 Reviewer Testing Required


✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX/<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@LeoKHoward LeoKHoward self-assigned this Jan 7, 2026
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@LeoKHoward LeoKHoward added enhancement New feature or request python Pull requests that update Python code postman Changes to the postman collection endpoints labels Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

endpoints enhancement New feature or request postman Changes to the postman collection python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant