Skip to content

NPA-6014: Interoperability patch consent changes #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristopherBacon merged 15 commits into from
Jan 13, 2026
Merged

NPA-6014: Interoperability patch consent changes #281

ChristopherBacon merged 15 commits into from
Jan 13, 2026

Conversation

@ChristopherBacon
Copy link
Contributor

@ChristopherBacon ChristopherBacon commented Dec 22, 2025 •
edited
Loading

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-6014

📄 Description/Summary of Changes

  • Updated date formatting for PATCH consent endpoints
  • Updated the provision object in the schema
  • Updated the examples for the schema to make provision an array

🧪 Developer Testing Carried Out

🧪 Reviewer Testing Required

  • Will need a check of the Postman collections to ensure they are correct and right environment

✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX/<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6014

@ChristopherBacon ChristopherBacon self-assigned this Dec 22, 2025
@ChristopherBacon ChristopherBacon added the OAS Updated the OpenAPI Specification (OAS) label Dec 22, 2025
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6014

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6014

@ChristopherBacon ChristopherBacon changed the title NPA-6014: Interoperability patch consent changes DRAFT NPA-6014: Interoperability patch consent changes Dec 23, 2025
@github-actions
Copy link

github-actions bot commented Jan 2, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6014

@ChristopherBacon ChristopherBacon changed the title DRAFT NPA-6014: Interoperability patch consent changes NPA-6014: Interoperability patch consent changes Jan 2, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6014

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6014

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6014

@github-actions
Copy link

github-actions bot commented Jan 12, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6014

ClarksonAdam
ClarksonAdam requested changes Jan 12, 2026
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6014

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6014

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6014

ClarksonAdam
ClarksonAdam requested changes Jan 13, 2026
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6014

ClarksonAdam
ClarksonAdam approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@ClarksonAdam ClarksonAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ChristopherBacon ChristopherBacon merged commit 5e0a2fc into master Jan 13, 2026
17 checks passed
@ChristopherBacon ChristopherBacon deleted the task/NPA-6014/interop-patch-consent-changes branch January 13, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ClarksonAdam ClarksonAdam ClarksonAdam approved these changes

Assignees

@ChristopherBacon ChristopherBacon

Labels

OAS Updated the OpenAPI Specification (OAS)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChristopherBacon @ClarksonAdam