Skip to content

SPINEDEM-5254 Enforce rate limit in INT #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
davidhamill1-nhs wants to merge 49 commits into
base: master
Choose a base branch
from
Open

SPINEDEM-5254 Enforce rate limit in INT #1163

davidhamill1-nhs wants to merge 49 commits into from

Conversation

@davidhamill1-nhs
Copy link
Contributor

@davidhamill1-nhs davidhamill1-nhs commented Jul 9, 2025

Summary

  • ⚠️ Enforce rate limit in INT and internal-dev

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.

agelledi and others added 30 commits June 3, 2025 17:08
@agelledi
SPINEDEM-5254 added initial ratelimit tests
b409ebb
@davidhamill1-nhs
Enforce app rate limiting in internal-dev.
36a066f
@agelledi
SPINEDEM-5254 added rate limit tests
9a42bf4
@agelledi
SPINEDEM-5254 reduced rate limit for testing
267d50e
@agelledi
SPINEDEM-5254 disabled spike arrest to confirm combined traffic behav…
af98ac2 
…iour
@agelledi
SPINEDEM-5254 enabled spikearrest config
3b9bf16
@agelledi
SPINEDEM-5254 increased proxy rate limit for testing
af50fe1
@agelledi
SPINEDEM-5254 update ratelimit test to run sequentially
4df88e7
@agelledi
SPINEDEM-5254 added commandline args for test
d3bf5b7
@davidhamill1-nhs
Enforce rate limit in INT.
215c191
@agelledi
SPINEDEM-524 reverted testing rate limit on internal dev
76dee69
@agelledi
SPINEDEM-5254 added review comment related changes
c0eb7cc
@davidhamill1-nhs
Merge branch 'master' into SPINEDEM-5254-add-rate-limit-tests-int
f39dd7c
@davidhamill1-nhs
Reduce code duplication.
45aace9
@davidhamill1-nhs
Reduce duplication of features.
1b01323
@davidhamill1-nhs
Reduce code duplication.
726f03f
@davidhamill1-nhs
Ensure the rateLimit testing is not picked up by the pipelines.
167e97e
@davidhamill1-nhs
Remove unused feature.
3e62ddd
@davidhamill1-nhs
Merge branch 'master' into SPINEDEM-5254-add-rate-limit-tests-int
b1a3118
@davidhamill1-nhs
responseStatus is an attribute of result.
a13532f
@davidhamill1-nhs
Revert "responseStatus is an attribute of result."
6d1e57d 
This reverts commit a13532f.
@davidhamill1-nhs
Run second app immediately after first.
26248c3
@davidhamill1-nhs
The feature file was moved out of its own directory.
5acf34f
@davidhamill1-nhs
Merge remote-tracking branch 'refs/remotes/origin/SPINEDEM-5254-add-r…
ca376c6 
…ate-limit-tests-int' into SPINEDEM-5254-add-rate-limit-tests-int
@davidhamill1-nhs
Merge commit 'b409ebb3cf0d2241df5ffd3b319f307fa840d5d0' into SPINEDEM…
730fef8 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Enforce app rate limiting in internal-dev.
cdc1e4a
@davidhamill1-nhs
Merge commit '9a42bf4992d2a4cddd8f60001dd35b6f27aa57af' into SPINEDEM…
9416ea9 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit '267d50ea211f3cbd9e70e8dd14e19abf46cc7bfa' into SPINEDEM…
33fbd3f 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit 'af98ac239cd218881ff7bb9656a825875dbd623f' into SPINEDEM…
68021cf 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit '3b9bf161813481d98ada0ba0f82428c5e0064ef6' into SPINEDEM…
e232910 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit 'af50fe104e9d8dc49729528f10d5866bae0d56ed' into SPINEDEM…
c2fb566 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit '4df88e72837b47b0c8b50898d446f3261069f997' into SPINEDEM…
29805c7 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit 'd3bf5b7c50e65c10968a8c4670c74f94e86386e6' into SPINEDEM…
1d1c607 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Enforce rate limit in INT.
45a6523
@davidhamill1-nhs
Merge commit '76dee69bdb4435a962684227988b16b7aa127810' into SPINEDEM…
7ced264 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit 'c0eb7cc9a0ea51f1909cc7806a4ad913191fcc93' into SPINEDEM…
d0bc4b2 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit 'f39dd7c5f95ea07da70b48cb410818019f91cbd6' into SPINEDEM…
735ecee 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit '45aace959af7bb0a052b0d917d50358822ea5bde' into SPINEDEM…
28f1416 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit '1b01323146e0aa558dd971d41130ab9b44f61d5f' into SPINEDEM…
a71ebcc 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit '726f03ffb49e215347d777dc361cab0a505f6451' into SPINEDEM…
6f9561e 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit '167e97e7b567cf4e2629f417725cbed0eb3cb419' into SPINEDEM…
e3733ad 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit '3e62ddda70202370ff9bde4ada20faf7ad84aad6' into SPINEDEM…
5dc9a35 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit 'b1a3118c492d5d3c4dcde6acb33b1a2aab2a7268' into SPINEDEM…
b9c3bc7 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit 'a13532fc1c8d60186080e1597fcfc4a45ecc3381' into SPINEDEM…
52ce43a 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit '6d1e57dd4e2bd284ad757aad2888c12bac2f478b' into SPINEDEM…
16e8873 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit '26248c3eb7315338066a63239393059963a5eea3' into SPINEDEM…
f52674a 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit '5acf34fcc8ecec9350358bc35f3d2626093f06c3' into SPINEDEM…
3ddda7b 
…-5254-add-rate-limit-tests-int-v3
@davidhamill1-nhs
Merge commit 'ca376c680502c339df8e34053b364be93e23b5db' into SPINEDEM…
b8155d1 
…-5254-add-rate-limit-tests-int-v3
@github-actions
Copy link

github-actions bot commented Jul 9, 2025

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-5254

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianmcgibbon fabianmcgibbon fabianmcgibbon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidhamill1-nhs @fabianmcgibbon @agelledi