CCM-11966: proof approved status #797
Merged
+2,792
−1,163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reflect new data if routing is enabled
… reflect new data if routing is enabled
…rove_and_submit_content_changes
…approve_and_submit_content_changes
…bmit_content_changes' into feature/CCM-11966_approve_and_submit_content_changes
chris-elliott-nhsd
previously approved these changes
Jan 23, 2026
alexnuttall
changed the base branch from
feature/CCM-11966_event-schema-string
to
main
alexnuttall
dismissed
chris-elliott-nhsd’s stale review
The base branch was changed.
…rove_and_submit_content_changes
harrim91
reviewed
Jan 26, 2026
lambdas/backend-api/src/infra/template-repository/repository.ts
Outdated
Show resolved
Hide resolved
harrim91
previously approved these changes
Jan 26, 2026
aidenvaines-cgi
previously approved these changes
Jan 26, 2026
nicki-nhs
reviewed
Jan 26, 2026
nicki-nhs
previously approved these changes
Jan 26, 2026
…rove_and_submit_content_changes
alexnuttall
dismissed stale reviews from nicki-nhs, aidenvaines-cgi, and harrim91
via
92e8cf0
aidenvaines-cgi
approved these changes
Jan 27, 2026
chris-elliott-nhsd
approved these changes
Jan 27, 2026
alexnuttall
deleted the
feature/CCM-11966_approve_and_submit_content_changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding letter template approval to the 'routing + PDF proofing' flow.
The existing
submit-letter-templatepage has new conditionally rendered content when routing is enabled. When clicking the approve button on this page, the existing/submitAPI route is used to update the template toPROOF_APPROVEDstatus. UnlikeSUBMITTEDtemplates, templates in this status can be deleted. The user is redirected tomessage-templatesinstead of theletter-template-submittedscreen. Clicking on an approved template on the message-templates screen takes you to thepreview-letterpage (notpreview-submitted-letter) - but there is no action button on the page.Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.